Load less data when changing todo state
What does this MR do and why?
Load less data when changing todo state
We don't need to know about all of the todo, just the id and the state is enough. This should remove some DB queries and make it slightly faster.
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- Extracted from !172107 (merged)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screen_Recording_2024-11-14_at_00.22.53
How to set up and validate locally
- Enable the
todos_vue_applicationfeature flag and go to http://gdk.test:3000/dashboard/todos/vue - Look at the GraphQL queries.
Merge request reports
Activity
assigned to @leipert
added pipelinetier-1 label
changed milestone to %17.6
@thutterer Could you please review? Thanks!
requested review from @thutterer
Reviewer roulette
Category Reviewer Maintainer frontend @ms.mondrian(UTC-5, 6 hours behind author)
@ntepluhina(UTC+1, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 590f5e9d and a415d0b2
Entrypoint / Name Size before Size after Diff Diff in percent average 4.41 MB 4.41 MB - 0.0 % mainChunk 3.32 MB 3.32 MB - 0.0 %
Note: We do not have exact data for 590f5e9d. So we have used data from: 94f870b8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Resolved by Natalia Tepluhina@leipert Thanks for splitting this into this small and easy to review MR! LGTM!
@ntepluhina Could you please maintainer review?
- Last reply by Natalia Tepluhina
requested review from @ntepluhina
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 29 | 0 | 5 | 0 | 34 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 398 | 0 | 45 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+e2e-test-on-cng:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Verify | 50 | 0 | 15 | 0 | 65 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Data Stores | 29 | 0 | 14 | 0 | 43 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Govern | 84 | 0 | 9 | 3 | 93 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 432 | 0 | 123 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Useradded pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
