Configure eslint job to output Code Quality report

What does this MR do?

• Add a dependency that allows eslint to create JSON reports that GitLab Code Quality can import.
• Configure the ESLint job to create such a report.

Note: the formatter only creates a report file if it detects that the process is running in CI. (It does this by looking for CI-related env vars.) This means that non-CI-based eslint runs are not affected and do not create such a file.

Verification

The functionality is demonstrated in a separate MR: !168587 (closed). That MR includes breaking a few lint rules to show that the report is successfully generated.

The report can be seen in a few places:

• MR widget:

  Click to expand

  

• Pipeline report

  • This report can time out with large reports; this is a preexisting issue that is not specific to this particular Code Quality report. It will also be mitigated as we remove CodeClimate-based scanning.

• MR Changes (diff) view:

  Click to expand

  

Related issues

Dogfood new direction for Code Quality in gitla... (#382153 - closed)

This is part of replacing CodeClimate-based scanning with direct usage of scanning tools. Dogfooding this approach will help accelerate the transition for customers.

Documentation will soon include these specific steps: Docs: Add catalog of common tools integrated wi... (!172633 - merged).

Checklist

Pre-merge

Consider the effect of the changes in this merge request on the following:

• Different pipeline types
• Non-canonical projects:
  • gitlab-foss
  • security
  • dev
  • personal forks
• Pipeline performance

If new jobs are added:

• Change-related rules (e.g. frontend/backend/database file changes): _____
• Frequency they are running (MRs, main branch, nightly, bi-hourly): _____
• Add a duration chart to https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations if there are new jobs added to merge request pipelines

This will help keep track of expected pipeline time and cost increases.

Post-merge

• Consider communicating these changes to the broader team following the communication guideline for pipeline changes

changed milestone to %17.6

added Category:Code Quality Engineering Productivity devopsapplication security testing groupstatic analysis maintenancepipelines sectionsec labels

added typemaintenance label

added pipelinetier-1 label

removed pipelinetier-1 typemaintenance labels

removed maintenancepipelines label

changed the description

Proper labels assigned to this merge request. Please ignore me.

@connorgilbert - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added maintenancepipelines typemaintenance labels

resolved all threads

added frontend label

	1 Warning
	This merge request added or updated artifact settings in CI YAML files. Please set restricted access if artifacts contain sensitive data.

Pipeline Changes

This merge request contains changes to the pipeline configuration for the GitLab project.

Please consider the effect of the changes in this merge request on the following:

• Effects on different pipeline types
• Effects on non-canonical projects:
  • gitlab-foss
  • security
  • dev
  • personal forks
• Effects on pipeline performance

Please consider communicating these changes to the broader team following the communication guideline for pipeline changes

Artifact settings updated in CI YAML files

The following files have updated artifact settings:

• .gitlab/ci/static-analysis.gitlab-ci.yml

Please verify if these artifacts contain sensitive data. If so, use the artifacts:access keyword to restrict download access.

Example of setting restricted access:

artifacts:
  access: developer

Reviewer roulette

Category	Reviewer	Maintainer
frontend	@vvempati (UTC+1)	@aturinske (UTC-8)
~"Pipeline configuration"	Reviewer review is optional for ~"Pipeline configuration"	@nao.hashizume (UTC+9)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

assigned to @connorgilbert

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 5c48ddb2 and aa3792d1

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.41 MB	4.41 MB	-	0.0 %
mainChunk	3.32 MB	3.32 MB	-	0.0 %

---

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

changed the description

changed the description

@djadmin would you do me the favor of a frontend review? I assume it is triggering because I touched package.json.

@ddavison could you please review this change to the pipeline configuration? The Verification section in this MR links to another MR where the functionality is demonstrated with some (synthetic) lint failures.

requested review from @djadmin and @ddavison