Configure eslint job to output Code Quality report
What does this MR do?
- Add a dependency that allows
eslint
to create JSON reports that GitLab Code Quality can import. - Configure the ESLint job to create such a report.
Note: the formatter only creates a report file if it detects that the process is running in CI. (It does this by looking for CI-related env vars.) This means that non-CI-based eslint
runs are not affected and do not create such a file.
Verification
The functionality is demonstrated in a separate MR: !168587 (closed). That MR includes breaking a few lint rules to show that the report is successfully generated.
The report can be seen in a few places:
-
MR widget:
-
- This report can time out with large reports; this is a preexisting issue that is not specific to this particular Code Quality report. It will also be mitigated as we remove CodeClimate-based scanning.
-
MR Changes (diff) view:
Related issues
Dogfood new direction for Code Quality in gitla... (#382153 - closed)
This is part of replacing CodeClimate-based scanning with direct usage of scanning tools. Dogfooding this approach will help accelerate the transition for customers.
Documentation will soon include these specific steps: Docs: Add catalog of common tools integrated wi... (!172633 - merged).
Checklist
Pre-merge
Consider the effect of the changes in this merge request on the following:
-
Different pipeline types - Non-canonical projects:
-
gitlab-foss
-
security
-
dev
-
personal forks
-
-
Pipeline performance
If new jobs are added:
-
Change-related rules (e.g. frontend/backend/database file changes): _____ -
Frequency they are running (MRs, main branch, nightly, bi-hourly): _____ -
Add a duration chart to https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations if there are new jobs added to merge request pipelines
This will help keep track of expected pipeline time and cost increases.
Post-merge
-
Consider communicating these changes to the broader team following the communication guideline for pipeline changes
Merge request reports
Activity
changed milestone to %17.6
added typemaintenance label
added pipelinetier-1 label
removed pipelinetier-1 typemaintenance labels
removed maintenancepipelines label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@connorgilbert
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added maintenancepipelines typemaintenance labels
- A deleted user
added frontend label
1 Warning This merge request added or updated artifact settings in CI YAML files.
Please set restricted access if artifacts contain sensitive data.Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Artifact settings updated in CI YAML files
The following files have updated artifact settings:
.gitlab/ci/static-analysis.gitlab-ci.yml
Please verify if these artifacts contain sensitive data. If so, use the
artifacts:access
keyword to restrict download access.Example of setting restricted access:
artifacts: access: developer
Reviewer roulette
Category Reviewer Maintainer frontend @vvempati
(UTC+1)
@aturinske
(UTC-8)
~"Pipeline configuration" Reviewer review is optional for ~"Pipeline configuration" @nao.hashizume
(UTC+9)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerassigned to @connorgilbert
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5c48ddb2 and aa3792d1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.41 MB 4.41 MB - 0.0 % mainChunk 3.32 MB 3.32 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Connor Gilbert
@djadmin would you do me the favor of a frontend review? I assume it is triggering because I touched
package.json
.@ddavison could you please review this change to the pipeline configuration? The Verification section in this MR links to another MR where the functionality is demonstrated with some (synthetic) lint failures.
mentioned in merge request !172641 (merged)
added pipeline:run-all-jest pipeline:run-all-jest-vue3 labels
requested review from @vitallium
added pipeline:mr-approved label
added pipelinetier-2 label
- Resolved by Connor Gilbert
added 1 commit
- 7ec26e77 - Move '--format gitlab' to CI config, out of yarn scripts
reset approvals from @djadmin by pushing to the branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for aa3792d1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for aa3792d1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for aa3792d1expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Package | 32 | 0 | 13 | 0 | 45 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Plan | 83 | 0 | 8 | 0 | 91 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 563 | 0 | 81 | 8 | 644 | ✅ | | Govern | 95 | 0 | 8 | 0 | 103 | ✅ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Secure | 5 | 0 | 3 | 0 | 8 | ✅ | | Manage | 26 | 0 | 19 | 1 | 45 | ✅ | | Systems | 6 | 0 | 1 | 0 | 7 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Ai-powered | 1 | 0 | 2 | 1 | 3 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 920 | 0 | 189 | 10 | 1109 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed pipeline:run-e2e-omnibus-once label
added 247 commits
-
7ec26e77...33ffe6f4 - 245 commits from branch
master
- ec1b2a05 - Configure eslint job to output Code Quality report
- aa3792d1 - Move '--format gitlab' to CI config, out of yarn scripts
-
7ec26e77...33ffe6f4 - 245 commits from branch
requested review from @djadmin
requested review from @ddavison
removed review request for @vitallium
- Resolved by Dheeraj Joshi
@djadmin looks like your approval got discarded because of the recent changes. Mind merging? (I don't have enough access to click the button.)
Edited by Connor Gilbert
mentioned in merge request !168587 (closed)
mentioned in merge request gitlab-ui!4834 (closed)
mentioned in merge request gitlab-ui!4820 (merged)