Modify /jwt/auth endpoint for registry tag protection feature
What does this MR do and why?
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/499874.
The rational behind the changes in this MR is described in detail here. These changes sit behind a new feature flag (https://gitlab.com/gitlab-org/gitlab/-/issues/505455+).
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- https://gitlab.com/gitlab-org/gitlab/-/issues/499874
- https://gitlab.com/groups/gitlab-org/-/epics/15608#jwt-auth
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Not applicable as the corresponding frontend changes (https://gitlab.com/gitlab-org/gitlab/-/issues/499871) are not yet implemented.
How to set up and validate locally
We'll assume that you have a gitlab-org/gitlab-test
project in your GDK, and a PAT from a user with Owner role with read/write registry permissions. Set the CR_PAT
environment variable to the PAT value and CR_USER
to the username.
For these tests I'm going to use the jq
and jwt
CLI tools to facilitate parsing the output of requests. Adjust the curl
commands if you don't want to use them (in which case you'll have to manually parse and decode the tokens).
-
First make a test with the FF disabled (default). To do so we need to obtain a token from the
/jwt/auth
endpoint:curl -s -u "$CR_USER:$CR_PAT" \ -G \ --data-urlencode "service=container_registry" \ --data-urlencode "scope=repository:gitlab-org/gitlab-test:pull,push" \ http://gdk.test:3000/jwt/auth | jq -r '.token' | jwt decode -j - | jq -r '.payload.access'
[ { "actions": [ "pull", "push" ], "meta": { "project_id": 2, "project_path": "gitlab-org/gitlab-test", "root_namespace_id": 24 }, "name": "gitlab-org/gitlab-test", "type": "repository" } ]
Note that there is no meta.tag_deny_access_patterns
key.
-
Now let's enable the FF for our project in the Rails console:
project = Project.find_by_full_path 'gitlab-org/gitlab-test' Feature.enable(:container_registry_protected_tags, project)
-
Repeat the request. You should see exactly the same output as there are no configured rules for this project.
-
Now let's create some rules:
project.container_registry_protection_tag_rules.create(tag_name_pattern: 'latest', minimum_access_level_for_push: Gitlab::Access::MAINTAINER, minimum_access_level_for_delete: Gitlab::Access::MAINTAINER) project.container_registry_protection_tag_rules.create(tag_name_pattern: 'precious', minimum_access_level_for_push: Gitlab::Access::OWNER, minimum_access_level_for_delete: Gitlab::Access::OWNER)
-
Repeat the request. You should see:
[ { "actions": [ "pull", "push" ], "meta": { "project_id": 2, "project_path": "gitlab-org/gitlab-test", "root_namespace_id": 24, "tag_deny_access_patterns": { "push": [] } }, "name": "gitlab-org/gitlab-test", "type": "repository" } ]
Note the meta.tag_deny_access_patterns
object is now present, and the empty push
array within, even though our user (as an admin) has no tag restrictions.
-
Now set the
CR_USER
andCR_PAT
variables to a username/PAT of a user with the Developer role in this project. -
Repeat the request. You should see:
[ { "actions": [ "pull", "push" ], "meta": { "project_id": 2, "project_path": "gitlab-org/gitlab-test", "root_namespace_id": 24, "tag_deny_access_patterns": { "push": [ "latest", "precious" ] } }, "name": "gitlab-org/gitlab-test", "type": "repository" } ]
-
Promote the user to Maintainer in this project, and then repeat the request. We can also test the
delete
action:curl -s -u "$CR_USER:$CR_PAT" \ -G \ --data-urlencode "service=container_registry" \ --data-urlencode "scope=repository:gitlab-org/gitlab-test:pull,push,delete" \ http://gdk.test:3000/jwt/auth | jq -r '.token' | jwt decode -j - | jq -r '.payload.access'
[ { "actions": [ "pull", "push", "delete" ], "meta": { "project_id": 2, "project_path": "gitlab-org/gitlab-test", "root_namespace_id": 24, "tag_deny_access_patterns": { "delete": [ "precious" ], "push": [ "precious" ] } }, "name": "gitlab-org/gitlab-test", "type": "repository" } ]
Database Review
Merge request reports
Activity
assigned to @jdrpereira
added devopspackage groupcontainer registry sectionci typefeature labels
added pipelinetier-1 label
- A deleted user
added backend label
9 Warnings 834d371e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 3b96dc58: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 85d40d2c: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 6be6f881: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. d5d2ec35: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 84f2c56d: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 35c8155b: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 830ff5d1: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @rliu-gl
(UTC-5, 5 hours behind author)
@harsimarsandhu
(UTC+5.5, 5.5 hours ahead of author)
database @acroitor
(UTC+2, 2 hours ahead of author)
@ahegyi
(UTC+1, 1 hour ahead of author)
groupauthentication Reviewer review is optional for groupauthentication @dblessing
(UTC-6, 6 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 483 commits
-
134ece27...a32c7f57 - 480 commits from branch
master
- 387380d5 - Modify registry JWT
- 0f45e560 - Fix path arg
- cc8f2aa2 - Split push/delete patterns
Toggle commit list-
134ece27...a32c7f57 - 480 commits from branch
added 1996 commits
-
cc8f2aa2...f051afac - 1993 commits from branch
master
- e71d74c5 - Modify registry JWT
- 864479fc - Fix path arg
- 04b50e34 - Split push/delete patterns
Toggle commit list-
cc8f2aa2...f051afac - 1993 commits from branch
- Resolved by João Pereira
- Resolved by João Pereira
- Resolved by João Pereira
- Resolved by João Pereira
added 582 commits
-
04b50e34...744589f6 - 579 commits from branch
master
- 2a92c068 - Modify registry JWT
- 4a2dea6a - Fix path arg
- 84e5e220 - Split push/delete patterns
Toggle commit list-
04b50e34...744589f6 - 579 commits from branch
added 1990 commits
-
84e5e220...90931360 - 1986 commits from branch
master
- f0ef9af0 - Modify registry JWT
- 3b3a7bdf - Fix path arg
- 7b6749b3 - Split push/delete patterns
- 7fd8dc2a - Refactor and add simple tests
Toggle commit list-
84e5e220...90931360 - 1986 commits from branch
- A deleted user
added feature flag label
- Resolved by João Pereira
- Resolved by João Pereira
added 2 commits
added Category:Container Registry featureaddition labels
changed milestone to %17.7
requested review from @adie.po
- Resolved by Alper Akgun
@adie.po
, could you review this?
- Resolved by David Fernandez
removed review request for @adie.po
mentioned in issue gitlab-com/www-gitlab-com#34902 (closed)
requested review from @10io
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by João Pereira
@ngeorge1, can you do the AppSec review?
requested review from @ngeorge1
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8542804907 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.23 s < 50.13 s #8542804907 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.18 s < 50.13 s #8542804838 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.89 s < 50.13 s #8542804838 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 54.64 s < 50.13 s #8558658114 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.86 s < 50.13 s #8558658114 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.16 s < 50.13 s #8558658304 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.51 s < 50.13 s #8558658304 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.97 s < 50.13 s #8559259539 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.35 s < 50.13 s #8559259539 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 51.56 s < 50.13 s #8559259389 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 64.11 s < 50.13 s #8559259389 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.8 s < 50.13 s #8566369526 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.95 s < 50.13 s #8566369526 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.26 s < 50.13 s #8566369910 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.32 s < 50.13 s #8566369910 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.48 s < 50.13 s #8566370063 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.33 s < 50.13 s #8566370063 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.54 s < 50.13 s #8566369727 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 64.15 s < 50.13 s #8566369727 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.27 s < 50.13 s #8567898511 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.05 s < 50.13 s #8567898511 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.46 s < 50.13 s #8567898648 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.81 s < 50.13 s #8567898648 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.38 s < 50.13 s #8567898781 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 64.21 s < 50.13 s #8567898781 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.33 s < 50.13 s #8567980962 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.99 s < 50.13 s #8567980962 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.11 s < 50.13 s #8598811134 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.83 s < 50.13 s #8598811134 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 51.38 s < 50.13 s #8598811217 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.0 s < 50.13 s #8598811217 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.8 s < 50.13 s #8598810913 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.27 s < 50.13 s #8598810913 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.66 s < 50.13 s #8598811021 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.87 s < 50.13 s #8598811021 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.51 s < 50.13 s #8610560513 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 61.76 s < 50.13 s #8610560513 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.62 s < 50.13 s #8610561019 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.06 s < 50.13 s #8610561019 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.46 s < 50.13 s #8610560867 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.44 s < 50.13 s #8610560867 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.72 s < 50.13 s #8610561194 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.74 s < 50.13 s #8610561194 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.37 s < 50.13 s - A deleted user
added rspec:slow test detected label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for afe6692aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 160 | 0 | 24 | 0 | 184 | ✅ | | Plan | 164 | 0 | 16 | 0 | 180 | ✅ | | Verify | 96 | 0 | 34 | 0 | 130 | ✅ | | Create | 270 | 0 | 40 | 0 | 310 | ✅ | | Manage | 2 | 0 | 18 | 0 | 20 | ✅ | | Fulfillment | 4 | 0 | 14 | 0 | 18 | ✅ | | Release | 10 | 0 | 2 | 0 | 12 | ✅ | | Data Stores | 66 | 0 | 20 | 0 | 86 | ✅ | | Package | 50 | 0 | 26 | 0 | 76 | ✅ | | Secure | 8 | 0 | 6 | 0 | 14 | ✅ | | Monitor | 16 | 0 | 24 | 0 | 40 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | Ai-powered | 0 | 0 | 4 | 0 | 4 | ➖ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 850 | 0 | 240 | 0 | 1090 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for afe6692aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Govern | 84 | 0 | 10 | 1 | 94 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Create | 140 | 0 | 19 | 1 | 159 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 4 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed review request for @ngeorge1
removed review request for @10io
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by David Fernandez
- A deleted user
added databasereview pending label
- Resolved by João Pereira
- Resolved by João Pereira
- Resolved by Alper Akgun
- A deleted user
added database label
- A deleted user
added Data WarehouseImpact Check label
requested review from @10io
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20241205143233 - AddIndexContainerRegistryProtectionTagRulesOnMinAccessLevel Post deploy 6.8 s +8.00 KiB [note] Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 0 0.1 seconds - 1 second 4 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20241205143233 - AddIndexContainerRegistryProtectionTagRulesOnMinAccessLevel
* Duration: 6.8 s
* Database size change: +8.00 KiB [note]Calls Total Time Max Time Mean Time Rows Query 1 4.7 ms 4.7 ms 4.7 ms 0 CREATE INDEX CONCURRENTLY "idx_container_registry_protection_tag_rules_on_min_access_level" ON "container_registry_protection_tag_rules" ("project_id", "minimum_access_level_for_push", "minimum_access_level_for_delete")
1 0.6 ms 0.6 ms 0.6 ms 1 SELECT "feature_gates"."key", "feature_gates"."value" FROM "feature_gates" WHERE "feature_gates"."feature_key" = $1
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddIndexContainerRegistryProtectionTagRulesOnMinAccessLevel
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 0 0.1 seconds - 1 second 4 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-3958083-16345809-main
2024-12-06T10:24:07Z 2024-12-04T22:48:46Z 2024-12-06 22:34:44 +0000 database-testing-3958083-16345809-ci
2024-12-06T10:24:08Z 2024-12-06T08:40:27Z 2024-12-06 22:34:44 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20241205143233 - AddIndexContainerRegistryProtectionTagRulesOnMinAccessLevel Post deploy 8.9 s +8.00 KiB [note] Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 0 0.1 seconds - 1 second 3 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20241205143233 - AddIndexContainerRegistryProtectionTagRulesOnMinAccessLevel
* Duration: 8.9 s
* Database size change: +8.00 KiB [note]Calls Total Time Max Time Mean Time Rows Query 1 4.8 ms 4.8 ms 4.8 ms 0 CREATE INDEX CONCURRENTLY "idx_container_registry_protection_tag_rules_on_min_access_level" ON "container_registry_protection_tag_rules" ("project_id", "minimum_access_level_for_push", "minimum_access_level_for_delete")
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddIndexContainerRegistryProtectionTagRulesOnMinAccessLevel
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 0 0.1 seconds - 1 second 3 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-3958083-16345809-main
2024-12-06T10:24:07Z 2024-12-04T22:48:46Z 2024-12-06 22:34:44 +0000 database-testing-3958083-16345809-ci
2024-12-06T10:24:08Z 2024-12-06T08:40:27Z 2024-12-06 22:34:44 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
Edited by ****added database-testing-automation label
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
- Resolved by João Pereira
requested review from @a_akgun
added databaseapproved label and removed databasereview pending label
mentioned in merge request !175251 (merged)
- Resolved by João Pereira
I see we're missing one approval from groupauthentication. Looks like we missed the non EE version of the registry auth service in !169108 (merged). I'll fix that in a followup: !175251 (merged)
requested review from @ifarkas
- Resolved by João Pereira
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
Alper Akgun removed this merge request from the merge train because the pipeline did not succeed.
Humm it seems like the merge pipeline got stuck (https://gitlab.com/gitlab-org/gitlab/-/pipelines/1583544348).
started a merge train
mentioned in commit 6c4c4cfa
Hello @jdrpereira
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. Improve it or delete it.
mentioned in merge request !175405 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label