Skip to content
Snippets Groups Projects

Config: update resolvement of eslint config from JiHu

Merged Wu Jeremy requested to merge gitlab-jh/jh-team/gitlab:eslint/update-linter-for-jihu into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

Right now if we use the JiHu eslint config as a shareable config, at the downstream, JiHu can only use overrides keywords to define certain override rules for some files, but unfortunately, overrides has its limitations, which does not allow keywords such as languageOptions. So I changed the plugin way to dynamic import the eslint file while jh/ subdirectory is present. To append the rules to the end of the configs array.

Config: update resolvement of eslint config from JiHu

  • Allowing JiHu to write their eslint configs for overriding.

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading