Skip to content
Snippets Groups Projects

Add docker pull to Container Registry CVS E2E spec

Merged Will Meek requested to merge container_reg_spec_docker_pull into master

What does this MR do and why?

Fix for https://gitlab.com/gitlab-org/gitlab/-/issues/501314

Ensure we run a docker pull on the base image before tagging for the Container Registry CVS spec

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

If it exists, remove alpine:3.10.0 and attempt to tag image should fail:

 % docker image rm alpine:3.10.0
Untagged: alpine:3.10.0
Untagged: alpine@sha256:ca1c944a4f8486a153024d9965aafbe24f5723c1d5c02f4964c045a16d19dc54

docker tag alpine:3.10.0 registry.staging.gitlab.com/gitlab-qa-sandbox-group-3/qa-test-2024-10-29-21-20-13-b40a4e8f84d61f17/container-registry-cvs-project-c09fd3745671b93b:latest
Error response from daemon: No such image: alpine:3.10.0

Run the test:

GITLAB_QA_USER_AGENT =<USER_AGENT> GITLAB_ADMIN_USERNAME=<ADMIN_USERNAME> GITLAB_ADMIN_PASSWORD="<ADMIN_PASSWORD>" GITLAB_USERNAME=<USERNAME> GITLAB_QA_ACCESS_TOKEN="<ACCESS_TOKEN>" GITLAB_PASSWORD="<GITLAB_PASSWORD>"  QA_DEBUG=true WEBDRIVER_HEADLESS=true bundle exec bin/qa Test::Instance::All https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/cvs_container_registry_spec.rb
Edited by Will Meek

Merge request reports

Merge train pipeline #1519965508 passed

Merge train pipeline passed for aba4c987

Approval is optional

Set by to be merged automatically when the pipeline succeeds

Ready to merge by members who can write to the target branch.

Merge details

  • 1 commit and 1 merge commit will be added to master (squashes 1 commit).
  • Source branch will be deleted.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading