fix: Add missing gitlab_sec schema to PrometheusAlertIndicator

Lucas Charlesrequested to merge
add-gitlab_sec-to-PrometheusAlertIndicator into master

What does this MR do and why?

fix: Add missing gitlab_sec schema to PrometheusAlertIndicator

PrometheusAlertIndicator needs an allowlist of all DB schemas, this adds the missing mapping for gitlab_sec.

See related CRs for enabling setting are in place on gstg and gprd

Changelog: fixed

Background

To better explain this as it's a rather confusing:

  1. We have several healthcheck indicators that inherit from PrometheusAlertIndicator. These are used to self-monitor and throttle batched migrations to avoid performance dips, see throttling batched migration docs.
  2. Since different migrations may tie to different DB connections (or instances entirely) the SLI/SLOs are derived from schemas.
  3. We define different SLI/SLO queries in application_settings based upon the schema name. The reason these are defined in app settings is because the indicator for a SM instance may be completely different than what we want to use for GitLab.com, so its configurable
  4. The current hashes do not have a dedicated key for the new gitlab_sec schema, this adds one (see parent issue)
  5. The query values of the gitlab_sec schema are dependent on CRs that require coordination with infrastructure
  6. The CRs essentially update application settings with a reference to sec
  7. until we complete the rollout of decomposition, this should be the equivalent of gitlab_main as we plan on splitting into two DB connections pointed at the same host.
  8. Once we complete rollout, we will perform a secondary set of CRs (gstg and gprd) to update the value of sec with the new patroni-sec value.

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lucas Charles

Merge request reports