Skip to content
Snippets Groups Projects

Randomize ssh and http port mappings for kind cluster

Merged Andrejs Cunskis requested to merge andrey-randomize-ports-cng into master
All threads resolved!

What does this MR do and why?

Add randomised node ports in order to reduce possibility of port collision that sometimes tend to happen on ci deployments. This does not prevent the issue completely, which could be done by allowing kubernetes to assign the open ports itself. This currently can't be implemented because the port values have to be known in advance for cluster configuration itself.

In addition this change removes ability to have a separate command for kind cluster creation. This is done because the need to know port mappings creates hard coupling between cluster creation and deployment. In order to avoid confusing issues, remove the custom cluster creation command and hardcode cluster name to ensure we would always reference cluster created by cng orchestrator.

Closes: Investigate port collision issues (gitlab-org/quality/quality-engineering/team-tasks#3127 - closed)
Part of: `cng` orchestrator improvements (gitlab-org/quality/quality-engineering/team-tasks#3067 - closed)

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andrejs Cunskis

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
  • Reviewer roulette

    Category Reviewer Maintainer
    QA @ghosh-abhinaba profile link current availability (UTC+5.5, 3.5 hours ahead of author) @sliaquat profile link current availability (UTC+5, 3 hours ahead of author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • added 1 commit

    • 1e79c321 - Randomize ssh and http port mappings for kind cluster

    Compare with previous version

  • Andrejs Cunskis resolved all threads

    resolved all threads

  • Andrejs Cunskis changed the description

    changed the description

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 1ee88850

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Create      | 129    | 0      | 19      | 0     | 148   | ✅     |
    | Package     | 17     | 0      | 18      | 0     | 35    | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Govern      | 76     | 0      | 3       | 1     | 79    | ✅     |
    | Verify      | 45     | 0      | 2       | 0     | 47    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 398    | 0      | 44      | 1     | 442   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 1ee88850

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 50     | 0      | 15      | 10    | 65    | ✅     |
    | Create      | 135    | 0      | 21      | 19    | 156   | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Data Stores | 33     | 0      | 10      | 1     | 43    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Govern      | 80     | 0      | 11      | 10    | 91    | ✅     |
    | Plan        | 82     | 0      | 8       | 12    | 90    | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure      | 1      | 0      | 6       | 0     | 7     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 423    | 0      | 122     | 52    | 545   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • added 1 commit

    Compare with previous version

  • Andrejs Cunskis requested review from @vburton

    requested review from @vburton

  • Valerie Burton
  • Valerie Burton approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Valerie Burton requested review from @chloeliu

    requested review from @chloeliu

  • Valerie Burton removed review request for @vburton

    removed review request for @vburton

  • Andrejs Cunskis changed the description

    changed the description

  • requested review from @treagitlab

  • Andrejs Cunskis removed review request for @chloeliu

    removed review request for @chloeliu

  • Tiffany Rea approved this merge request

    approved this merge request

  • Tiffany Rea resolved all threads

    resolved all threads

  • Tiffany Rea enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Tiffany Rea mentioned in commit 22bf1d58

    mentioned in commit 22bf1d58

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading