Randomize ssh and http port mappings for kind cluster
What does this MR do and why?
Add randomised node ports in order to reduce possibility of port collision that sometimes tend to happen on ci deployments. This does not prevent the issue completely, which could be done by allowing kubernetes to assign the open ports itself. This currently can't be implemented because the port values have to be known in advance for cluster configuration itself.
In addition this change removes ability to have a separate command for kind
cluster creation. This is done because the need to know port mappings creates hard coupling between cluster creation and deployment. In order to avoid confusing issues, remove the custom cluster creation command and hardcode cluster name to ensure we would always reference cluster created by cng
orchestrator.
Closes: Investigate port collision issues (gitlab-org/quality/quality-engineering/team-tasks#3127 - closed)
Part of: `cng` orchestrator improvements (gitlab-org/quality/quality-engineering/team-tasks#3067 - closed)
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
changed milestone to %17.6
assigned to @acunskis
added pipelinetier-1 label
- A deleted user
added QA label
- Resolved by Andrejs Cunskis
- Resolved by Andrejs Cunskis
added Quality label
- Resolved by Andrejs Cunskis
Reviewer roulette
Category Reviewer Maintainer QA @ghosh-abhinaba
(UTC+5.5, 3.5 hours ahead of author)
@sliaquat
(UTC+5, 3 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 1 commit
- 1e79c321 - Randomize ssh and http port mappings for kind cluster
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1ee88850expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Govern | 76 | 0 | 3 | 1 | 79 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 398 | 0 | 44 | 1 | 442 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 1ee88850expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Create | 135 | 0 | 21 | 19 | 156 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Data Stores | 33 | 0 | 10 | 1 | 43 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Govern | 80 | 0 | 11 | 10 | 91 | ✅ | | Plan | 82 | 0 | 8 | 12 | 90 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 423 | 0 | 122 | 52 | 545 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Tiffany Rea
@vburton Could You please do the initial code review?
requested review from @vburton
- Resolved by Tiffany Rea
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
requested review from @chloeliu
removed review request for @vburton
- Resolved by Tiffany Rea
@treagitlab Would You mind taking maintainer review from Chloe as she is taking sick leave today?
requested review from @treagitlab
removed review request for @chloeliu
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit 22bf1d58
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label