Fix Style/IfUnlessModifier offences
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
Fixing offences for -
- 'app/models/appearance.rb'
- 'app/models/application_setting_implementation.rb'
- 'app/models/bulk_imports/entity.rb'
- 'app/models/ci/application_record.rb'
- 'app/models/ci/build.rb'
- 'app/models/ci/build_trace_chunk.rb'
- 'app/models/ci/job_artifact.rb'
- 'app/models/ci/pending_build.rb'
- 'app/models/ci/pipeline.rb'
- 'app/models/ci/runner.rb'
Related to #239356
Merge request reports
Activity
added Engineering Productivity typemaintenance labels
added pipelinetier-1 label
Thanks for your contribution to GitLab @divyamtayal!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo! Check out the top of the merge request description to learn more about using AI while contributing.
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @divyamtayal
This merge request will be counted as part of the running Hackathon!
Find yourself in the Hackathon Leaderboard or check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
added linked-issue label
4 Warnings 5c2b337f: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.Labels missing: please ask a reviewer or maintainer to add backend to this merge request. Reviewer roulette
Category Reviewer Maintainer backend @fdegier
(UTC+1)
@nmilojevic1
(UTC+1)
~"Verify" Reviewer review is optional for ~"Verify" @drew
(UTC+0)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Danger Bot@gitlab-bot ready @splattael
added workflowready for review label and removed workflowin dev label
requested review from @splattael
@splattael, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
- Please ensure the group's Product Manager has validated the linked issue.
This message was generated automatically. You're welcome to improve it.
added 951 commits
-
8b649a55...4fed3d07 - 950 commits from branch
gitlab-org:master
- 969eaa93 - Merge branch 'master' into '239356-fix-Style/IfUnlessModifier_4'
-
8b649a55...4fed3d07 - 950 commits from branch
- Resolved by Divyam Tayal
- Resolved by drew stachon
@splattael Pls review this.
changed milestone to %17.6