Skip to content

Prevent choosing invalid pat expiration date picker values

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

Prevent choosing invalid pat expiration date picker values.

Both min and max date where incorrect. Now max date follows this rules:

Type Require expiration date on Require expiration date off
CE Max: 365/400 days (depending on the buffered_token_expiration_limit FF) No max date
EE
  • Max: 365/400 days (when max_personal_access_token_lifetime is blank)
  • Max: X days (when max_personal_access_token_lifetime is X < 365)
No max date

Closes #432403 (closed)

Closes #508503 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

🛠️ with ❤️ at Siemens

/cc @bufferoverflow @max-wittig @nejch @fh1ch @ercan.ucan

Edited by Eduardo Sanz García

Merge request reports

Loading