Model registry: Improve empty model description state
What does this MR do and why?
This MR changes the empty state of the description of a Model in line with the design.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Open GDK: http://127.0.0.1:3000/flightjs/Flight/-/ml/models
- Create model if one doesn't exist, give it a model name and click
Create
. Leave the descriptions empty - Verify that the descriptions points to the empty state with instructions to edit the description
Related to #498844 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @fdegier
added 3 commits
-
98f1ed0f...bb488293 - 2 commits from branch
master
- a9b45df7 - Model registry: Improve empty modelcard state
-
98f1ed0f...bb488293 - 2 commits from branch
- A deleted user
added frontend label
3 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/ml/model_registry/components/model_detail.vue
+ <div v-else class="gl-text-secondary" data-testid="empty-description-state">
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @lindsey-shelton
(UTC-5, 7 hours behind author)
@deepika.guliani
(UTC+5.5, 3.5 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3aabc5b1 and ecee83d6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.39 MB 4.39 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 3aabc5b1. So we have used data from: 08834541.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost User- Resolved by Coung Ngo
Hi @lindsey-shelton could you do the frontend reviewer review please?
requested review from @lindsey-shelton
- Resolved by Lindsey Shelton
added 1 commit
- ecee83d6 - Model registry: Improve empty version description state
requested review from @lindsey-shelton
added pipeline:mr-approved label