Add feature flag for index circuit breakers
What does this MR do and why?
Add feature flag for zoekt index circuit breakers
Until we have index level eviction logic, we don't want to skip indexing when an index watermark is exceeded.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
added groupglobal search label
assigned to @johnmason
added devopsdata stores sectioncore platform labels
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@johnmason
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added docs-only label
added 1 commit
- bf660d13 - Add feature flag for zoekt index circuit breakers
added maintenancescalability label
added typemaintenance label
removed docs-only label
@rkumar555 can you do initial review here?
requested review from @rkumar555
- A deleted user
added backend feature flag labels
Reviewer roulette
Category Reviewer Maintainer backend @tigerwnz
(UTC+11, 15 hours ahead of author)
@pskorupa
(UTC+2, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by John Mason
@johnmason Looks good to me. Just one question, should we add some expectation in the test when FF
zoekt_index_circuit_breaker
istrue
?
requested review from @terrichu and removed review request for @rkumar555
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
- Resolved by John Mason
reset approvals from @rkumar555 by pushing to the branch
changed milestone to %17.5
requested review from @terrichu
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f1eb8fb0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 152 | 0 | 0 | 0 | 152 | ✅ | | Verify | 90 | 0 | 4 | 0 | 94 | ✅ | | Data Stores | 66 | 0 | 2 | 0 | 68 | ✅ | | Package | 34 | 0 | 36 | 0 | 70 | ✅ | | Create | 256 | 0 | 36 | 0 | 292 | ✅ | | Secure | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 142 | 0 | 4 | 0 | 146 | ✅ | | Monitor | 16 | 0 | 0 | 0 | 16 | ✅ | | Manage | 2 | 0 | 2 | 0 | 4 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 10 | 0 | 0 | 0 | 10 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 784 | 0 | 84 | 0 | 868 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for f1eb8fb0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 9 | 94 | ✅ | | Create | 139 | 0 | 20 | 13 | 159 | ✅ | | Govern | 79 | 0 | 10 | 8 | 89 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Secure | 4 | 0 | 2 | 0 | 6 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 433 | 0 | 116 | 40 | 549 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for f1eb8fb0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 164 | 0 | 16 | 0 | 180 | ✅ | | Create | 678 | 0 | 100 | 0 | 778 | ✅ | | Govern | 158 | 0 | 16 | 0 | 174 | ✅ | | Data Stores | 66 | 0 | 20 | 0 | 86 | ✅ | | Verify | 100 | 0 | 30 | 0 | 130 | ✅ | | Release | 10 | 0 | 2 | 0 | 12 | ✅ | | Fulfillment | 4 | 0 | 14 | 0 | 18 | ✅ | | Ai-powered | 0 | 0 | 4 | 0 | 4 | ➖ | | Package | 50 | 0 | 26 | 0 | 76 | ✅ | | Secure | 8 | 0 | 4 | 2 | 12 | ✅ | | Monitor | 16 | 0 | 24 | 0 | 40 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Manage | 4 | 0 | 16 | 0 | 20 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 1262 | 0 | 284 | 2 | 1546 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
changed milestone to %17.6
added missed:17.5 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 87a1f56c
added workflowstaging-canary label
@johnmason This merge request was deployed to the workflowstaging-canary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set zoekt_index_circuit_breaker true --staging
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowcanary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set zoekt_index_circuit_breaker true --production
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowstaging environment. You may want to enable the associated feature flag on this environment with/chatops run feature set zoekt_index_circuit_breaker true --staging
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowproduction environment. You may want to enable the associated feature flag on this environment with/chatops run feature set zoekt_index_circuit_breaker true --production
.This message was generated automatically. You're welcome to improve it.
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added devopsfoundations label and removed devopsdata stores label