Skip to content
Snippets Groups Projects

Add feature flag for index circuit breakers

Merged John Mason requested to merge jm-feature-flag-index-circuit-breakers into master
1 unresolved thread

What does this MR do and why?

Add feature flag for zoekt index circuit breakers

Until we have index level eviction logic, we don't want to skip indexing when an index watermark is exceeded.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by John Mason

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Terri Chu requested changes

    requested changes

  • John Mason added 1 commit

    added 1 commit

    • f1eb8fb0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • John Mason reset approvals from @rkumar555 by pushing to the branch

    reset approvals from @rkumar555 by pushing to the branch

  • John Mason changed milestone to %17.5

    changed milestone to %17.5

  • John Mason requested review from @terrichu

    requested review from @terrichu

  • Terri Chu approved this merge request

    approved this merge request

  • Terri Chu resolved all threads

    resolved all threads

  • Terri Chu enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for f1eb8fb0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 152    | 0      | 0       | 0     | 152   | ✅     |
    | Verify      | 90     | 0      | 4       | 0     | 94    | ✅     |
    | Data Stores | 66     | 0      | 2       | 0     | 68    | ✅     |
    | Package     | 34     | 0      | 36      | 0     | 70    | ✅     |
    | Create      | 256    | 0      | 36      | 0     | 292   | ✅     |
    | Secure      | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Govern      | 142    | 0      | 4       | 0     | 146   | ✅     |
    | Monitor     | 16     | 0      | 0       | 0     | 16    | ✅     |
    | Manage      | 2      | 0      | 2       | 0     | 4     | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Fulfillment | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Release     | 10     | 0      | 0       | 0     | 10    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 784    | 0      | 84      | 0     | 868   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for f1eb8fb0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 86     | 0      | 8       | 9     | 94    | ✅     |
    | Create      | 139    | 0      | 20      | 13    | 159   | ✅     |
    | Govern      | 79     | 0      | 10      | 8     | 89    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Verify      | 50     | 0      | 15      | 10    | 65    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Secure      | 4      | 0      | 2       | 0     | 6     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 433    | 0      | 116     | 40    | 549   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :white_check_mark: test report for f1eb8fb0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 164    | 0      | 16      | 0     | 180   | ✅     |
    | Create      | 678    | 0      | 100     | 0     | 778   | ✅     |
    | Govern      | 158    | 0      | 16      | 0     | 174   | ✅     |
    | Data Stores | 66     | 0      | 20      | 0     | 86    | ✅     |
    | Verify      | 100    | 0      | 30      | 0     | 130   | ✅     |
    | Release     | 10     | 0      | 2       | 0     | 12    | ✅     |
    | Fulfillment | 4      | 0      | 14      | 0     | 18    | ✅     |
    | Ai-powered  | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Package     | 50     | 0      | 26      | 0     | 76    | ✅     |
    | Secure      | 8      | 0      | 4       | 2     | 12    | ✅     |
    | Monitor     | 16     | 0      | 24      | 0     | 40    | ✅     |
    | Configure   | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Manage      | 4      | 0      | 16      | 0     | 20    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | ModelOps    | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Growth      | 0      | 0      | 4       | 0     | 4     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 1262   | 0      | 284     | 2     | 1546  | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • changed milestone to %17.6

  • merged

  • Terri Chu mentioned in commit 87a1f56c

    mentioned in commit 87a1f56c

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading