Skip to content
Snippets Groups Projects

Migrate groups Bootstrap utils to Tailwind

Merged Peter Hegman requested to merge migrate-groups-bootstrap-utils-to-tailwind into master

What does this MR do and why?

We are working on migrating the Bootstrap CSS utils to Tailwind CSS so we can reduce the amount of CSS we ship to the customer. https://bootstrap-to-tailwind-css-migration-tracker-cf87ab.gitlab.io/#/ is where we are tracking this. This MR migrates the code in app/assets/javascripts/groups

Reviewer notes

  1. The spacing scale is different between Bootstrap CSS utils and Tailwind CSS utils. We figured out all the Tailwind equivalents in https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/bin/lib/bootstrap_tailwind_equivalents.json?ref_type=heads and use that for migration.
  2. Almost all Bootstrap CSS utils have !important set. This can make things tricky because a lot of the time it is not needed. In this MR I have removed the !important from the utils that it was not necessary for because I was able to easily test locally.

MR acceptance checklist

Desktop

Before After
Screenshot_2024-10-04_at_10.10.59_AM Screenshot_2024-10-04_at_10.09.17_AM

Mobile

Before After
Screenshot_2024-10-04_at_10.11.17_AM Screenshot_2024-10-04_at_10.09.31_AM

How to set up and validate locally

  1. Checkout this branch
  2. Go to a group that has subgroups and projects
Edited by Peter Hegman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Hegman requested review from @vanessaotto

    requested review from @vanessaotto

  • Vanessa Otto approved this merge request

    approved this merge request

  • Vanessa Otto requested review from @psimyn

    requested review from @psimyn

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for d064d725

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Govern      | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Verify      | 45     | 0      | 2       | 0     | 47    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Create      | 128    | 0      | 18      | 0     | 146   | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 401    | 0      | 33      | 0     | 434   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :x: test report for d064d725

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Package        | 32     | 0      | 13      | 0     | 45    | ✅     |
    | Govern         | 108    | 0      | 6       | 0     | 114   | ✅     |
    | Systems        | 6      | 0      | 1       | 0     | 7     | ✅     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Ai-powered     | 1      | 0      | 2       | 0     | 3     | ✅     |
    | Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
    | Create         | 559    | 0      | 80      | 1     | 639   | ✅     |
    | Secure         | 5      | 0      | 2       | 0     | 7     | ✅     |
    | Plan           | 83     | 0      | 8       | 0     | 91    | ✅     |
    | Fulfillment    | 4      | 0      | 7       | 0     | 11    | ✅     |
    | Manage         | 25     | 2      | 18      | 5     | 45    | ❌     |
    | Data Stores    | 46     | 0      | 11      | 0     | 57    | ✅     |
    | Verify         | 50     | 0      | 15      | 1     | 65    | ✅     |
    | Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
    | Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
    | ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 942    | 2      | 184     | 7     | 1128  | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading