Remove snowplow property/label from some events Frontend
What does this MR do and why?
Updating below events :
-
click_button
, click_search_result
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #483068
Merge request reports
Activity
changed milestone to %17.5
assigned to @ankit.panchal
added pipelinetier-1 label
2 Warnings The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:ee/app/assets/javascripts/vue_shared/security_reports/components/security_training_promo.vue
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @freinink
(UTC-6, 11.5 hours behind author)
@ghinfey
(UTC+1, 4.5 hours behind author)
frontend @jmontal
(UTC-6, 11.5 hours behind author)
@mfluharty
(UTC-6, 11.5 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fcf93c07 and 1e922253
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.37 MB 4.37 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for fcf93c07. So we have used data from: 94ed792c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost User- Resolved by Jonas Larsen
@j_lar Can you please review this MR
requested review from @j_lar
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7995127022 ee/spec/features/groups/work_items/work_item_spec.rb#L45
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 65.55 s < 50.13 s #7996954485 ee/spec/features/groups/work_items/work_item_spec.rb#L45
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 59.42 s < 50.13 s Edited by Ghost User- A deleted user
added rspec:slow test detected label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1e922253expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Plan | 76 | 0 | 0 | 1 | 76 | ✅ | | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 1 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 1e922253expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Create | 408 | 0 | 60 | 0 | 468 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 422 | 0 | 74 | 0 | 496 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userremoved pipeline:run-e2e-omnibus-once label
added this merge request to the merge train at position 6