POC: Render the user profile tabs in Vue Router (!168023) · Merge requests · GitLab.org / GitLab · GitLab

Snippets Groups Projects

Closed Shane Maglangit requested to merge 497477-encapsulate-vue-profile-tabs-in-vue-router into master 5 months ago

What does this MR do and why?

Refactors the current profile_tabs.vue to a route rendered in a Vue Router. This is the ground work needed so that we can progressively move the individual tab items and move them into the sidebar menu (see #389842).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

In rails console enable the profile_tabs_vue feature flag
```
Feature.enable(:profile_tabs_vue)
```
Visit a user's profile page (http://localhost:3000/root)
There should be no functional difference. Both the sidebar menu and tabs should work normally.

Related to #389842 #497477 (closed)

Edited 5 months ago by Shane Maglangit

Activity

Shane Maglangit changed milestone to %17.5 5 months ago

changed milestone to %17.5
Shane Maglangit added frontend grouptenant scale maintenancerefactor typemaintenance labels 5 months ago

added frontend grouptenant scale maintenancerefactor typemaintenance labels
🤖 GitLab Bot 🤖 added devopsdata stores sectioncore platform labels 5 months ago

added devopsdata stores sectioncore platform labels
🤖 GitLab Bot 🤖 added pipelinetier-1 label 5 months ago

added pipelinetier-1 label
A deleted user added backend label 5 months ago

added backend label
Ghost User @ghost1 · 5 months ago

Contributor

Reviewer roulette

Category Reviewer Maintainer

backend @jwanjohi (UTC+1) @mcelicalderonG (UTC-5)

frontend @viktomas (UTC+2) @ekigbo (UTC+10)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger
Shane Maglangit changed the description 5 months ago

changed the description
Shane Maglangit resolved all threads 5 months ago

resolved all threads
Shane Maglangit @smaglangit started a thread on an old version of the diff 5 months ago

lib/sidebars/user_profile/panel.rb

       private
       def add_legacy_menu?
         # When `profile_tabs_vue` feature flag is enabled, legacy profile views
         # will be replaced by components in `app/assets/javascripts/profile/components/router_views`

Shane Maglangit added 1 commit 5 months ago

added 1 commit

edd9c150 - Update `add_legacy_menu?` comment

Compare with previous version

Ghost User @ghost1 · 5 months ago

Contributor

Generated by gitlab_quality-test_tooling.

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7982477781	`spec/features/admin/users/users_spec.rb#L177`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.09 s	< 50.13 s
#7983449815	`spec/features/admin/users/users_spec.rb#L177`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.54 s	< 50.13 s
#7984594316	`spec/features/admin/users/users_spec.rb#L177`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.09 s	< 50.13 s
#7986687155	`spec/features/admin/users/users_spec.rb#L177`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.52 s	< 50.13 s
#7987355857	`spec/features/admin/users/users_spec.rb#L177`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	65.92 s	< 50.13 s
#7991668290	`spec/features/admin/users/users_spec.rb#L177`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	65.88 s	< 50.13 s

A deleted user added label 5 months ago

added rspec:slow test detected label

Ghost User @ghost1 · 5 months ago

Contributor

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 8fc6e0d5 and 76198de8

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.37 MB	4.37 MB	-	0.0 %
mainChunk	3.3 MB	3.3 MB	-	0.0 %

Significant Growth: 5

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.users	511.38 KB	595.34 KB	+83.96 KB	16.4 %
pages.users.identity_verification.show	746.02 KB	829.98 KB	+83.96 KB	11.3 %
pages.users.registrations_identity_verification.arkose_labs_challenge	526.66 KB	610.62 KB	+83.96 KB	15.9 %
pages.users.registrations_identity_verification.show	746.02 KB	829.98 KB	+83.96 KB	11.3 %
pages.users.terms.index	526.8 KB	610.77 KB	+83.96 KB	15.9 %

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@leipert, @markrian, @pgascouvaillancourt, @sdejonge or @thutterer) for review, if you are unsure about the size increase.

Note: We do not have exact data for 8fc6e0d5. So we have used data from: 081358cf.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Read more about how this report works.

Generated by Danger

Shane Maglangit changed title from Draft: Encapsulate user profile tabs into vue router to Draft: Render the user profile tabs using the Vue Router 5 months ago

changed title from Draft: Encapsulate user profile tabs into vue router to Draft: Render the user profile tabs using the Vue Router

Shane Maglangit changed the description 5 months ago

changed the description

Shane Maglangit changed the description 5 months ago

changed the description

Shane Maglangit added 1 commit 5 months ago

added 1 commit

6d071020 - Render user profile tabs in Vue Router

Compare with previous version

Shane Maglangit changed title from Draft: Render the user profile tabs using the Vue Router to Draft: POC: Render the user profile tabs using the Vue Router 5 months ago

changed title from Draft: Render the user profile tabs using the Vue Router to Draft: POC: Render the user profile tabs using the Vue Router

Shane Maglangit changed title from Draft: POC: Render the user profile tabs using the Vue Router to Draft: [POC] Render the user profile tabs using the Vue Router 5 months ago

changed title from Draft: POC: Render the user profile tabs using the Vue Router to Draft: [POC] Render the user profile tabs using the Vue Router

Shane Maglangit closed 5 months ago

closed

Shane Maglangit changed title from Draft: [POC] Render the user profile tabs using the Vue Router to Draft: Render the user profile tabs using the Vue Router 5 months ago

changed title from Draft: [POC] Render the user profile tabs using the Vue Router to Draft: Render the user profile tabs using the Vue Router

Shane Maglangit reopened 5 months ago

reopened

Shane Maglangit assigned to @smaglangit 5 months ago

assigned to @smaglangit

Shane Maglangit added 577 commits 5 months ago

added 577 commits

6d071020...2d04b418 - 576 commits from branch master
636aaab2 - Render user profile tabs in Vue Router

Compare with previous version

Shane Maglangit added 1 commit 5 months ago

added 1 commit

fbe840fd - Render user profile tabs in Vue Router

Compare with previous version

Shane Maglangit added 1 commit 5 months ago

added 1 commit

79cdb2ac - Render user profile tabs in Vue Router

Compare with previous version

Shane Maglangit changed title from Draft: Render the user profile tabs using the Vue Router to Draft: Render the user profile tabs in Vue Router 5 months ago

changed title from Draft: Render the user profile tabs using the Vue Router to Draft: Render the user profile tabs in Vue Router

Shane Maglangit added 1 commit 5 months ago

added 1 commit

da006c49 - Fix profile tabs alignment

Compare with previous version

Shane Maglangit removed label 5 months ago

removed backend label

A deleted user added label 5 months ago

added backend label

Shane Maglangit changed the description 5 months ago

changed the description

Shane Maglangit added 2 commits 5 months ago

added 2 commits

88487939 - Rename ProfileApp to UserProfileApp
ba7d86e4 - Remove unused mock

Compare with previous version

Shane Maglangit marked this merge request as ready 5 months ago

marked this merge request as ready

Shane Maglangit changed title from Draft: Render the user profile tabs in Vue Router to POC: Render the user profile tabs in Vue Router 5 months ago

changed title from Draft: Render the user profile tabs in Vue Router to POC: Render the user profile tabs in Vue Router

Shane Maglangit added 1 commit 5 months ago

added 1 commit

16a60137 - Render user profile tabs in Vue Router

Compare with previous version

Shane Maglangit added 2 commits 5 months ago

added 2 commits

1fbec4ad - Fix profile router import
76198de8 - Add missing router prop

Compare with previous version

Shane Maglangit closed 5 months ago

closed

Please register or sign in to reply