Allow watermarks to transition from high to low for zoekt indices

John Masonrequested to merge
jm-zoekt-remove-high-watermark-on-indices into master

What does this MR do and why?

Allow watermarks to transition from high to low for zoekt indices

The changes here update the should_have_low_watermark to include indices that have high watermark but used storage that only exceed the low watermark.

Closes #497443 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports