Migrate Admin group edit page to use SettingsSection component
What does this MR do and why?
- Migrates Admin group edit page to use
SettingsSection
component instead of the deprecated side-by-side view - Fixes a problem where the divider between
SettingsSection
's would not show up (added test urls)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
Bugfix of divider not showing up | |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- http://gdk.test:3000/admin/groups
- Edit a random group
Test URLs for the divider bugfix:
- http://gdk.test:3000/-/user_settings/profile
- http://gdk.test:3000/-/profile/preferences
- http://gdk.test:3000/-/user_settings/personal_access_tokens
- http://gdk.test:3000/groups/flightjs/-/settings/packages_and_registries
Related to #474921 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @seggenberger
added devopsfoundations label
added sectioncore platform label and removed sectiondev label
added pipelinetier-1 label
- Resolved by Sascha Eggenberger
requested review from @jmiocene
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @missy-gitlab
(UTC-4, 6 hours behind author)
@reprazent
(UTC+2, same timezone as author)
frontend @kkloss
(UTC+2, same timezone as author)
@svedova
(UTC+2, same timezone as author)
UX @jmiocene
(UTC+2, same timezone as author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved review request for @jmiocene
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 38d5bfa4 and b9554dae
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.37 MB 4.37 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 38d5bfa4. So we have used data from: 4aab6162.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b9554daeexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 0 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Savas Vedova
requested review from @kkloss
requested review from @svedova
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed review request for @kkloss
- Resolved by Savas Vedova
started a merge train
mentioned in commit 7404cf0e
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3429 (merged)