Skip to content
Snippets Groups Projects

Migrate Admin group edit page to use SettingsSection component

Merged Sascha Eggenberger requested to merge admin-edit-group-cleanup into master
All threads resolved!

What does this MR do and why?

  • Migrates Admin group edit page to use SettingsSection component instead of the deprecated side-by-side view
  • Fixes a problem where the divider between SettingsSection's would not show up (added test urls)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
Bugfix of divider not showing up
before1 after1
before2 after2
before3 after3
before4 after4

How to set up and validate locally

  1. http://gdk.test:3000/admin/groups
  2. Edit a random group

Test URLs for the divider bugfix:

  1. http://gdk.test:3000/-/user_settings/profile
  2. http://gdk.test:3000/-/profile/preferences
  3. http://gdk.test:3000/-/user_settings/personal_access_tokens
  4. http://gdk.test:3000/groups/flightjs/-/settings/packages_and_registries

Related to #474921 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Savas Vedova approved this merge request

    approved this merge request

  • Savas Vedova resolved all threads

    resolved all threads

  • Savas Vedova enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Savas Vedova mentioned in commit 7404cf0e

    mentioned in commit 7404cf0e

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading