Add Duo Enterprise product interaction for seat assignment lead
What does this MR do and why?
Add Duo Enterprise product interaction for seat assignment lead
- we need to handle duo pro and duo enterprise for the iterable lead triggers on user assignment.
- implement a new bulk worker as it will be faster to see the impact AND the worker name could be improved.
- Fix a bug with the bulk worker where Set was being passed instead of an array.
- see Add product interaction value for duo enterpris... (#495116 - closed)
Changelog: other EE: true
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #495116 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @dstull
added pipelinetier-1 label
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Category Reviewer Maintainer backend @tyleramos
(UTC-4, same timezone as author)
@a_akgun
(UTC+3, 7 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
onboarding_add_on_seat_assignment_iterable_trigger
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Hordur Freyr Yngvason
added 1 commit
- a1a6378f - Add Duo Enterprise product interaction for seat assignment lead
- Resolved by Hordur Freyr Yngvason
- Resolved by Hordur Freyr Yngvason
I have reviewed the merge request and left a mix of questions and recommendations. The review covers topics such as potential bugs, constant accessibility, query optimization, functionality removal, worker behavior changes, and test coverage. I estimate there is a decent amount of work required to address these comments, particularly regarding the functionality removal and ensuring proper test coverage.
Edited by GitLab Duo- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull