Only show custom emoji from current group in frequently used emoji
What does this MR do and why?
Currently, the user's frequently used emojis group shows their 9 most recently used emoji, regardless of whether they are custom emoji in the current group or not. This means that custom emojis that are not from the current group will show as a "?" placeholder in the frequently used category.
This MR filters those emojis out of the Frequently Used category.
Screenshots or screen recordings
In the screenshots below, the user's 9 most recently used emojis include 2 emoji that are custom emoji within a different group than the current page's group.
Before | After |
---|---|
![]() |
![]() |
Here the emoji picker is seen within the group that owns those custom emojis (note: there is no change here):
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch
- In the GDK, add one or more custom emojis in a group (you can do this at http://gdk.test:3000/groups/flightjs/-/custom_emoji/). Let's refer to this group as Group A.
- Use at least one of Group A's custom emojis you have added to react to an issue or MR inside Group A. You should see it in your frequently used emojis list.
- Navigate to a different group in the GDK. Let's call this group Group B.
- Use the emoji award button on an issue or MR
- You should not see any of the Group A custom emojis in your frequently used emojis list.
Merge request reports
Activity
changed milestone to %17.5
added UX Paper Cuts bugux groupknowledge labels
assigned to @clavimoniere
added typebug label
added pipelinetier-1 label
added devopsplan sectiondev labels
mentioned in issue #491761
- A deleted user
added frontend label
1 Warning The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer frontend @mcavoj
(UTC+2, 7 hours ahead of author)
@wortschi
(UTC+2, 7 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Chad Lavimoniere
@jmiocene can you give this a UX Paper Cuts review?
requested review from @jmiocene
removed review request for @jmiocene
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f5d58930 and 993a7811
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.37 MB 4.37 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for f5d58930. So we have used data from: 85c28057.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 993a7811expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Plan | 76 | 0 | 0 | 1 | 76 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 1 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 993a7811expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 408 | 0 | 60 | 0 | 468 | ✅ | | Plan | 83 | 0 | 8 | 0 | 91 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 491 | 0 | 68 | 0 | 559 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Chad Lavimoniere
requested review from @wortschi
- Resolved by Chad Lavimoniere
added 1 commit
- 15d9bd3a - Only show custom emoji from current group in frequently used emoji
- Resolved by Chad Lavimoniere
added 1 commit
- 009c8eec - Only show custom emoji from current group in frequently used emoji
added 1 commit
- 009c8eec - Only show custom emoji from current group in frequently used emoji
added 1 commit
- 009c8eec - Only show custom emoji from current group in frequently used emoji
added 1 commit
- 009c8eec - Only show custom emoji from current group in frequently used emoji
added 1 commit
- 993a7811 - Only show custom emoji from current group in frequently used emoji
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
Hey there
, could you please make sure this merge request gets merged?The merge request is set to auto-merge, but it is not currently mergeable (MR
detailed_merge_status
is discussions_not_resolved).This message was generated automatically. You're welcome to improve it.
started a merge train
mentioned in commit 9c8d6056
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3429 (merged)
35 35 swapCookieToLocalStorage(); 36 36 } 37 37 38 const emojis = chunk(uniq(savedEmojis.split(',')), 9); 38 const customEmoji = await loadCustomEmojiWithNames(); Just an FYI - this caused a performance regression causing the emoji menu to be slow when opening. This method re-fetches all the custom emoji for the group even if they have already been loaded. I am working on a fix in !170460 (merged)
mentioned in issue #474921 (closed)