Skip to content
Snippets Groups Projects

Only show custom emoji from current group in frequently used emoji

1 unresolved thread

What does this MR do and why?

Currently, the user's frequently used emojis group shows their 9 most recently used emoji, regardless of whether they are custom emoji in the current group or not. This means that custom emojis that are not from the current group will show as a "?" placeholder in the frequently used category.

This MR filters those emojis out of the Frequently Used category.

Screenshots or screen recordings

In the screenshots below, the user's 9 most recently used emojis include 2 emoji that are custom emoji within a different group than the current page's group.

Before After
image image

Here the emoji picker is seen within the group that owns those custom emojis (note: there is no change here):

Before After
image image

How to set up and validate locally

  1. Check out this branch
  2. In the GDK, add one or more custom emojis in a group (you can do this at http://gdk.test:3000/groups/flightjs/-/custom_emoji/). Let's refer to this group as Group A.
  3. Use at least one of Group A's custom emojis you have added to react to an issue or MR inside Group A. You should see it in your frequently used emojis list.
  4. Navigate to a different group in the GDK. Let's call this group Group B.
  5. Use the emoji award button on an issue or MR
  6. You should not see any of the Group A custom emojis in your frequently used emojis list.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 15d9bd3a - Only show custom emoji from current group in frequently used emoji

    Compare with previous version

  • added 1 commit

    • 009c8eec - Only show custom emoji from current group in frequently used emoji

    Compare with previous version

  • added 1 commit

    • 009c8eec - Only show custom emoji from current group in frequently used emoji

    Compare with previous version

  • added 1 commit

    • 009c8eec - Only show custom emoji from current group in frequently used emoji

    Compare with previous version

  • added 1 commit

    • 009c8eec - Only show custom emoji from current group in frequently used emoji

    Compare with previous version

  • added 1 commit

    • 993a7811 - Only show custom emoji from current group in frequently used emoji

    Compare with previous version

  • Martin Wortschack approved this merge request

    approved this merge request

  • Martin Wortschack enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Hey there :wave:, could you please make sure this merge request gets merged?

    The merge request is set to auto-merge, but it is not currently mergeable (MR detailed_merge_status is discussions_not_resolved).

    This message was generated automatically. You're welcome to improve it.

  • Chad Lavimoniere resolved all threads

    resolved all threads

  • mentioned in commit 9c8d6056

  • added workflowstaging label and removed workflowcanary label

  • 35 35 swapCookieToLocalStorage();
    36 36 }
    37 37
    38 const emojis = chunk(uniq(savedEmojis.split(',')), 9);
    38 const customEmoji = await loadCustomEmojiWithNames();
    • Just an FYI - this caused a performance regression causing the emoji menu to be slow when opening. This method re-fetches all the custom emoji for the group even if they have already been loaded. I am working on a fix in !170460 (merged)

    • Please register or sign in to reply
  • mentioned in issue #474921 (closed)

  • Please register or sign in to reply
    Loading