VSA: Split TypeOfWorkCharts into loader/chart components
What does this MR do and why?
Follow-up to !166170 (merged) which broke the default storybook example due to moving the data fetching out of Vuex.
Refactors the TypeOfWorkCharts
component into TypeOfWorkChartsLoader
/TypeOfWorkCharts
components, which handle the data loading/rendering respectively.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Ensure you are using GitLab Ultimate
- Create a new Project
- Generate mock data:
FILTER=customizable_cycle_analytics SEED_CUSTOMIZABLE_CYCLE_ANALYTICS=1 VSA_SEED_PROJECT_ID=${PROJECT_ID} bundle exec rake db:seed_fu
- Navigate to VSA for the owning group of the project created:
Analyze > Value stream analytics
- Validate that the
Tasks by type
chart (bottom of the Overview tab) works with different labels/Merge requests
Via storybook
yarn storybook:start
- Navigate to the type of work charts story: http://localhost:9002/?path=/story/ee-analytics-cycle-analytics-components-type-of-work-charts--default
- Verify that the stories render with meaningful data
Related to #492101 (closed)
Edited by Alex Pennells