Skip to content

VSA: Split TypeOfWorkCharts into loader/chart components

What does this MR do and why?

Follow-up to !166170 (merged) which broke the default storybook example due to moving the data fetching out of Vuex.

Refactors the TypeOfWorkCharts component into TypeOfWorkChartsLoader/TypeOfWorkCharts components, which handle the data loading/rendering respectively.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-09-27_at_2.33.20_PM Screenshot_2024-09-27_at_2.32.16_PM

How to set up and validate locally

  1. Ensure you are using GitLab Ultimate
  2. Create a new Project
  3. Generate mock data: FILTER=customizable_cycle_analytics SEED_CUSTOMIZABLE_CYCLE_ANALYTICS=1 VSA_SEED_PROJECT_ID=${PROJECT_ID} bundle exec rake db:seed_fu
  4. Navigate to VSA for the owning group of the project created: Analyze > Value stream analytics
  5. Validate that the Tasks by type chart (bottom of the Overview tab) works with different labels/Merge requests

Via storybook

  1. yarn storybook:start
  2. Navigate to the type of work charts story: http://localhost:9002/?path=/story/ee-analytics-cycle-analytics-components-type-of-work-charts--default
  3. Verify that the stories render with meaningful data

Related to #492101 (closed)

Edited by Alex Pennells

Merge request reports

Loading