Value Stream analytics: Move tasks by type request out of Vuex action
What does this MR do and why?
This is part of a continued effort to remove the typeOfWork
Vuex module used by the Value stream analytics app. This MR begins to migrate the Vuex actions into the TypeOfWorkCharts
component.
Summary:
- Replaces
fetchTasksByTypeData
Vuex action withfetchTasksByType
component method - Replaces
data
Vuex state attribute withtasksByType
component data attribute
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
No visual changes
How to set up and validate locally
- Ensure you are using GitLab Ultimate
- Create a new Project
- Generate mock data:
FILTER=customizable_cycle_analytics SEED_CUSTOMIZABLE_CYCLE_ANALYTICS=1 VSA_SEED_PROJECT_ID=${PROJECT_ID} bundle exec rake db:seed_fu
- Navigate to VSA for the owning group of the project created:
Analyze > Value stream analytics
- Validate that the
Tasks by type
chart (bottom of the Overview tab) works with different labels/Merge requests
Related to #477817 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @apennells
added pipelinetier-1 label
Reviewer roulette
Category Reviewer Maintainer frontend @fernando-c
(UTC-5, 1 hour behind author)
@pslaughter
(UTC-5, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- a84e3b18 - Value Stream analytics: Move tasks by type request out of Vuex action
- Resolved by Ezekiel Kigbo
@nradina Would you mind doing the initial review, and then passing off to
@ekigbo
for the maintainer review?
added workflowin review label and removed workflowready for development label
requested review from @nradina
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d1b5feaa and a84e3b18
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - -0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for d1b5feaa. So we have used data from: 0dae63b4.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
requested review from @ekigbo
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a84e3b18expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 17 | 0 | 145 | ✅ | | Plan | 75 | 0 | 1 | 1 | 76 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Verify | 46 | 0 | 2 | 0 | 48 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 400 | 0 | 33 | 1 | 433 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for a84e3b18expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 80 | 0 | 9 | 0 | 89 | ✅ | | Create | 399 | 0 | 63 | 0 | 462 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 479 | 0 | 72 | 0 | 551 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Ezekiel Kigbo
- Resolved by Ezekiel Kigbo
mentioned in issue #492101 (closed)
Great work @apennells thanks for initiating and pushing forward with this refactor and thanks for the good discussions, i've opened a follow-up issue but can go ahead and merge this for now.
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
added this merge request to the merge train at position 2
mentioned in commit cbc2e182
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-com/www-gitlab-com#34665 (closed)
mentioned in merge request !167487 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !174195 (merged)