Move combined trial params to correct trial creation flow
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/468028
What does this MR do and why?
Moves the CDot trial creation params to the correct trial registration flow.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
There are no visual changes
How to set up and validate locally
- Setup CDot locally - https://gitlab.com/gitlab-org/customers-gitlab-com/-/tree/b263f1abe9db0c1c8098471b9b6d8476dc8c1f77#setup
- Set GL env var to local CDot via: CUSTOMER_PORTAL_URL=http://localhost:5000/
- Create a new GL user
- Signup for Ultimate trial
- Verify you also got the Duo Enterprise account.
Related to #468028
Merge request reports
Activity
changed milestone to %17.4
assigned to @davidhampgonsalves
added pipelinetier-1 label
- A deleted user
added backend label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @jwanjohi
(UTC+1, 4 hours ahead of author)
@marc_shaw
(UTC+2, 5 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userremoved backend label
added 1 commit
- d7aa48a9 - Move combined trial params to correct trial creation flow
- A deleted user
added backend label
added 1 commit
- 21e79edb - Move combined trial params to correct trial creation flow
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7944592709 ee/spec/features/registrations/saas/trial_flow_just_me_importing_project_spec.rb#L14
Trial flow for user picking just me and importing a project with regular trial sign up registers the user and starts to import a project 62.43 s < 50.13 s #7947117710 ee/spec/features/registrations/saas/trial_flow_just_me_importing_project_spec.rb#L14
Trial flow for user picking just me and importing a project with sso trial sign up registers the user and starts to import a project 55.83 s < 50.13 s #7948421045 ee/spec/features/registrations/saas/trial_flow_just_me_importing_project_spec.rb#L14
Trial flow for user picking just me and importing a project with regular trial sign up registers the user and starts to import a project 59.86 s < 50.13 s #7951997654 ee/spec/features/registrations/saas/trial_flow_just_me_importing_project_spec.rb#L14
Trial flow for user picking just me and importing a project with sso trial sign up registers the user and starts to import a project 60.86 s < 50.13 s Edited by Ghost User- A deleted user
added rspec:slow test detected label
added 1 commit
- 8e3dfa11 - Move combined trial params to correct trial creation flow
added 1 commit
- 7c485504 - Move combined trial params to correct trial creation flow
added 1 commit
- 6a2674fb - Move combined trial params to correct trial creation flow
added 1 commit
- b8025135 - Move combined trial params to correct trial creation flow