Set AutoMergeProcessWorker data consistency to sticky
What does this MR do and why?
Set AutoMergeProcessWorker data consistency to sticky
There's not a lot of immediate benefit to doing this, but we are preparing some other changes that will move a very high-volume read query out of the PipelineProcessWorker and into this worker, where it will hit replicas before the merge process actually starts.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
changed milestone to %17.5
requested review from @marc_shaw
assigned to @drew
added pipelinetier-1 label
added Category:Continuous Integration (CI) Scaling label
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @panoskanell
(UTC+3, 3 hours ahead of author)
@ifarkas
(UTC+2, 2 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alejandro Rodríguez
Hey @marc_shaw! This is something that we split off of !167095 (comment 2127936869), because it's an easy enough change to make separately and immediately.
We don't expect immediate changes, but it's something we'll want to do along with !167095 (merged) and there doesn't appear to be any cost to changing it now.
Could you do primary & domain review here, to make sure there's nothing I'm forgetting that means we can't do this?
mentioned in merge request !167095 (merged)
added 1067 commits
-
b5881c29...05a6967c - 1066 commits from branch
master
- b8a7dc83 - Set AutoMergeProcessWorker data consistency to sticky
-
b5881c29...05a6967c - 1066 commits from branch
- Resolved by drew stachon
removed review request for @marc_shaw
added 626 commits
-
b8a7dc83...b72ab69b - 625 commits from branch
master
- 63fcf37c - Set AutoMergeProcessWorker data consistency to sticky
-
b8a7dc83...b72ab69b - 625 commits from branch
added 1 commit
- 82cce8c1 - Use feature flag for AutoMergeProcessWorker consistency
- A deleted user
added feature flag feature flagexists labels
requested review from @marc_shaw
mentioned in issue #496567 (closed)
added 32 commits
-
82cce8c1...a4678d1e - 30 commits from branch
master
- 183de654 - Set AutoMergeProcessWorker data consistency to sticky
- 7f8c2160 - Use feature flag for AutoMergeProcessWorker consistency
-
82cce8c1...a4678d1e - 30 commits from branch
added 62 commits
-
7f8c2160...b40fdd42 - 60 commits from branch
master
- 6e51077d - Set AutoMergeProcessWorker data consistency to sticky
- 318cbf66 - Use feature flag for AutoMergeProcessWorker consistency
-
7f8c2160...b40fdd42 - 60 commits from branch
requested review from @alejandro
added pipeline:mr-approved label
removed review request for @marc_shaw
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ba7ad56bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Plan | 76 | 0 | 0 | 1 | 76 | ✅ | | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Verify | 90 | 0 | 4 | 0 | 94 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 446 | 0 | 35 | 1 | 481 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 318cbf66expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Verify | 100 | 0 | 30 | 2 | 130 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 100 | 0 | 30 | 2 | 130 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
- Resolved by drew stachon
added 275 commits
-
318cbf66...6a920f22 - 273 commits from branch
master
- 902e78b7 - Set AutoMergeProcessWorker data consistency to sticky
- 2c3f73f8 - Use feature flag for AutoMergeProcessWorker consistency
-
318cbf66...6a920f22 - 273 commits from branch
reset approvals from @marc_shaw by pushing to the branch
added 1 commit
- 17817553 - Use feature flag for AutoMergeProcessWorker consistency
added 335 commits
-
17817553...6a920f22 - 333 commits from branch
master
- ff6138bd - Set AutoMergeProcessWorker data consistency to sticky
- 3d0be075 - Use feature flag for AutoMergeProcessWorker consistency
-
17817553...6a920f22 - 333 commits from branch
removed review request for @alejandro
requested review from @alejandro and @marc_shaw
removed review request for @marc_shaw
- Resolved by Alejandro Rodríguez
Upstream CI failures: gitlab-org/quality/engineering-productivity/master-broken-incidents#8682 (closed)
added 24 commits
-
3d0be075...4327e7d6 - 22 commits from branch
master
- 59d99527 - Set AutoMergeProcessWorker data consistency to sticky
- ba7ad56b - Use feature flag for AutoMergeProcessWorker consistency
-
3d0be075...4327e7d6 - 22 commits from branch
added this merge request to the merge train at position 2
mentioned in commit f8e1d3d5
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #483008 (closed)
mentioned in merge request !168123 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#20609 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20967 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21571 (closed)
mentioned in merge request !177639 (merged)