Skip to content
Snippets Groups Projects

Resolve Vulnerabilities::StarboardVulnerabilityCreateService cross transaction issues

What does this MR do and why?

This MR removes the cross DB interaction suppresion from the described service as part of the sec-decomposition and remediates the code to work post decomposition. This required updates to the cluster_agents and projects tables to be moved out of the transaction as those updates will go to the main DB as averse to the Sec DB.

This does carry the unfortunate theoretical consequence that information could theoretically desyncronize if there is a failure after the execution of the initial transaction, unlikely as that is. We are currently considering implementing data consistency checks to fix problems like these should they arise.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #476584 (closed)

Edited by Gregory Havenga

Merge request reports

Merge train pipeline #1484818743 passed

Merge train pipeline passed for 6d6d871c

Merged by Michał ZającMichał Zając 5 months ago (Oct 7, 2024 2:24pm UTC)

Loading

Pipeline #1484842190 passed

Pipeline passed for f3ed0239 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading