VSD – Remove old metrics for tracking drill-down click events
What does this MR do and why?
- Removes the deprecated
value_streams_dashboard_metric_link_clickedandvalue_streams_dashboard_${metric_identifier}_link_clickedevents from both the Value Streams Dashboard and AI impact dashboard - Migrates the
trackEventcall to the sharedMetricTableCellcomponent
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
No visible change
How to set up and validate locally
- Please make sure that you have a GitLab Ultimate license.
- Start the internal events monitor
rails runner scripts/internal_events/monitor.rb click_metric_in_dashboard_table(see docs for more info) - Navigate to any Value streams dashboard (ex.
http://gdk.test:3000/groups/flightjs/-/analytics/dashboards/value_streams_dashboard) - Verify that clicking any metric name tracks the event
- Navigate to any AI impact dashboard (ex.
http://gdk.test:3000/groups/flightjs/-/analytics/dashboards/ai_impact) - Verify that clicking any metric name tracks the event
Related to #469128 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @apennells
added pipelinetier-1 label
4 Warnings 
This merge request is quite big (651 lines changed), please consider splitting it into multiple merge requests. 0aff5560: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 0aff5560: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 92a16868: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer analytics instrumentation @nisong
(UTC+2, 6 hours ahead of author)Maintainer review is optional for analytics instrumentation frontend @a_akgun (UTC+3, 7 hours ahead of author)@svedova (UTC+2, 6 hours ahead of author)Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a84175fb and 0aff5560
Entrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - 0.0 % mainChunk 3.29 MB 3.29 MB - 0.0 %
Note: We do not have exact data for a84175fb. So we have used data from: 5be36fb6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
- A deleted user
added analytics instrumentationreview pending label
- A deleted user
added Data WarehouseImpact Check label
added 2 commits
added 1 commit
- 57df9ca8 - Remove legacy event tracking from Value Streams Dashboard
Resolved by Savas Vedova@a_akgun Mind handling the initial review here?
- Last reply by Savas Vedova
