Migrate "Instance audit events" empty result page to EmptyResult component
What does this MR do and why?
Migrate "Instance audit events" empty result page to EmptyResult component
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Merge request reports
Activity
changed milestone to %17.4
added UX Paper Cuts groupcompliance typemaintenance labels
assigned to @jmiocene
mentioned in epic gitlab-org#15100
added pipelinetier-1 label
added devopsgovern sectionsec labels
- A deleted user
added frontend label
1 Warning 31036076: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @a_akgun
(UTC+3, 1 hour ahead of author)
@dpisek
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1e7f91ab and 31036076
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.36 MB 4.36 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 1e7f91ab. So we have used data from: a95e62c8.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Julia Miocene
@clavimoniere
Could you please review UX here?
requested review from @clavimoniere
added 1 commit
- 50bc2a89 - Migrate "Instance audit events" empty result page to EmptyResult component
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Payton Burdette
requested review from @dftian
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 31036076expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Package | 23 | 0 | 12 | 0 | 35 | ✅ | | Create | 128 | 0 | 17 | 0 | 145 | ✅ | | Plan | 75 | 0 | 1 | 1 | 76 | ✅ | | Verify | 46 | 0 | 2 | 0 | 48 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 399 | 0 | 34 | 1 | 433 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 50bc2a89expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 108 | 0 | 5 | 2 | 113 | ✅ | | Create | 408 | 0 | 51 | 0 | 459 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 516 | 0 | 56 | 2 | 572 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
requested review from @pburdette and removed review request for @dftian
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
- Resolved by Payton Burdette
@jmiocene we keep getting a failed pipeline here, maybe we can try a rebase?
aborted automatic add to merge train because the source branch was updated. Learn more.
added 775 commits
-
50bc2a89...d5f16b0b - 774 commits from branch
master
- 9baffe00 - Migrate "Instance audit events" empty result page to EmptyResult component
-
50bc2a89...d5f16b0b - 774 commits from branch
aborted automatic add to merge train because the source branch was updated. Learn more.
added 550 commits
-
9baffe00...f5b12883 - 549 commits from branch
master
- 31036076 - Migrate "Instance audit events" empty result page to EmptyResult component
-
9baffe00...f5b12883 - 549 commits from branch
- Resolved by Payton Burdette
Rebasing, hope it'll help
changed milestone to %17.5
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
WE DID IT! Thanks, @pburdette
Way rougher than it should have been @jmiocene
started a merge train
mentioned in commit 1698a139
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label