Skip to content
Snippets Groups Projects

Add config file class for C++ Conan `conanfile.txt`

Merged Leaminn Ma requested to merge add-cpp-conantxt-config-file-class into master
All threads resolved!

What does this MR do and why?

Background

The Repository X-Ray is a tool that searches for dependency manager configuration files (aka "lock files") and then extracts a list of libraries from the content.

In #474306 (comment 2025085630), we decided to migrate the Repository X-Ray functionality into the GitLab Rails monolith. This gives us two main benefits: (i) it will eventually allow us to run the service outside of the CI pipeline, and (ii) we can maintain the parsing logic centrally so that other domains can utilize it.

Base MR

In !162313 (merged), we introduced the ConfigFiles::Base class where the intention is for each dependency manager config file type to be represented by a child class. The child class contains the parsing logic to extract a list of libraries and their versions from the file content.

This MR

In this MR, we introduce the CppConanTxt config file class that parses conanfile.txt.

For references to the existing parsing logic in the Repository X-Ray repo, see:

Resolves part of #476177 (closed).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #476177 (closed)

Edited by Leaminn Ma

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Missy Davies approved this merge request

    approved this merge request

  • Missy Davies requested review from @dmeshcharakou and removed review request for @missy-gitlab

    requested review from @dmeshcharakou and removed review request for @missy-gitlab

  • Leaminn Ma added 1 commit

    added 1 commit

    • bba2fe78 - Added an inline comment example

    Compare with previous version

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for bba2fe78

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 128    | 0      | 16      | 0     | 144   | ✅     |
    | Plan        | 74     | 0      | 1       | 0     | 75    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 391    | 0      | 33      | 0     | 424   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :white_check_mark: test report for bba2fe78

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Create | 551    | 0      | 68      | 0     | 619   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 551    | 0      | 68      | 0     | 619   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Dzmitry (Dima) Meshcharakou approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Dzmitry (Dima) Meshcharakou enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • resolved all threads

  • Dzmitry (Dima) Meshcharakou added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • mentioned in commit 6844cb93

  • added workflowstaging label and removed workflowcanary label

  • Leaminn Ma mentioned in merge request !166516 (merged)

    mentioned in merge request !166516 (merged)

  • Please register or sign in to reply
    Loading