Skip to content
Snippets Groups Projects

Show new notification button in work item sticky header when flag is on

All threads resolved!

What does this MR do and why?

Show new notification button in work item sticky header when flag is on

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Check out this branch
  2. Make sure you have the notifications_todos_buttons feature flag turned on in the GDK
  3. Visit a work item (not the modal version of a task, the full page)
  4. Ensure you are seeing the todo and notification buttons in the regular header on the work item
  5. scroll so that the sticky header is showing

You should see the todo and notification buttons, and you should not see a notification item in the action menu.

Related to #480263 (closed), #469616 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Natalia Tepluhina requested changes

    requested changes

  • requested review from @ntepluhina

  • added 1 commit

    • 6d055399 - Add specs for notificationsTodoButtons FF

    Compare with previous version

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Natalia Tepluhina enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #7760701064 ee/spec/features/groups/work_items/work_item_spec.rb#L46 Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 54.25 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 6d055399

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Create      | 128    | 0      | 16      | 0     | 144   | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 389    | 0      | 32      | 0     | 421   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :white_check_mark: test report for 6d055399

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Create | 408    | 0      | 51      | 0     | 459   | ✅     |
    | Plan   | 82     | 0      | 9       | 0     | 91    | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 490    | 0      | 60      | 0     | 550   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
  • mentioned in commit 2cdd5ea0

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading