Skip to content
Snippets Groups Projects

Extract base dropdown logic

Merged Artur Fedorov requested to merge 480637-policies-group-scope-extract-base-logic into master
All threads resolved!

What does this MR do and why?

This MR request is a part of bigger MR

Scope of this MR:

  1. Create folder for shared dropdown components
  2. Extract common logic to base_items_dropdown
  3. Update group_projects_dropdown.vue to use new base dropdown
  4. Add tests, update existing

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
NO VISUAL CHANGES Screenshot 2024-09-04 at 00.02.04.png

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable feature flag:

    echo "Feature.enable(:policy_group_scope)" | rails c
  2. Go to a group

  3. Secure -> Policies

  4. New policy => any type

  5. Make sure there is an option all projects in linked groups

  6. Make sure groups dropdown and projects dropdown work

Related to #480637 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Čavoj
  • Martin Čavoj requested review from @aturinske and removed review request for @mcavoj

    requested review from @aturinske and removed review request for @mcavoj

  • Martin Čavoj approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 4866234d

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 128    | 0      | 16      | 0     | 144   | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 389    | 0      | 32      | 0     | 421   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :x: test report for 4866234d

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 107    | 1      | 5       | 2     | 113   | ❌     |
    | Create | 408    | 0      | 51      | 0     | 459   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 515    | 1      | 56      | 2     | 572   | ❌     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Artur Fedorov added 433 commits

    added 433 commits

    Compare with previous version

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Alexander Turinske resolved all threads

    resolved all threads

  • mentioned in commit 10d1dfec

  • Artur Fedorov mentioned in merge request !163998 (merged)

    mentioned in merge request !163998 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading