Extract base dropdown logic
What does this MR do and why?
This MR request is a part of bigger MR
Scope of this MR:
- Create folder for shared dropdown components
- Extract common logic to
base_items_dropdown
- Update
group_projects_dropdown.vue
to use new base dropdown - Add tests, update existing
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
NO VISUAL CHANGES |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
Enable feature flag:
echo "Feature.enable(:policy_group_scope)" | rails c
-
Go to a group
-
Secure -> Policies
-
New policy => any type
-
Make sure there is an option
all projects in linked groups
-
Make sure groups dropdown and projects dropdown work
Related to #480637 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @arfedoro
added pipelinetier-1 label
- Resolved by Artur Fedorov
@mcavoj could you please review this MR.
It has a lot of files changed, but most of it just import path update
requested review from @mcavoj
2 Warnings This merge request is quite big (560 lines changed), please consider splitting it into multiple merge requests. e77d2ca6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer frontend @apennells
(UTC-4, 6 hours behind author)
@rob.hunt
(UTC+1, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6ed36e99 and 4866234d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for 6ed36e99. So we have used data from: 4c35b330.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
requested review from @aturinske and removed review request for @mcavoj
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 4866234dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 4866234dexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 107 | 1 | 5 | 2 | 113 | ❌ | | Create | 408 | 0 | 51 | 0 | 459 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 515 | 1 | 56 | 2 | 572 | ❌ | +--------+--------+--------+---------+-------+-------+--------+
added 433 commits
-
d8eada92...add538d0 - 429 commits from branch
master
- 59409ae4 - This MR adds linked items dropdown
- e77d2ca6 - Added descendant groups
- 7ced5844 - This MR extract common logic
- 4866234d - Applied review changes
Toggle commit list-
d8eada92...add538d0 - 429 commits from branch
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 10d1dfec
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8313 (closed)
mentioned in merge request !163998 (merged)
added workflowstaging-canary label and removed workflowrefinement label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label