Skip to content

Extract base dropdown logic

Artur Fedorov requested to merge 480637-policies-group-scope-extract-base-logic into master

What does this MR do and why?

This MR request is a part of bigger MR

Scope of this MR:

  1. Create folder for shared dropdown components
  2. Extract common logic to base_items_dropdown
  3. Update group_projects_dropdown.vue to use new base dropdown
  4. Add tests, update existing

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
NO VISUAL CHANGES Screenshot 2024-09-04 at 00.02.04.png

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable feature flag:

    echo "Feature.enable(:policy_group_scope)" | rails c

  2. Go to a group

  3. Secure -> Policies

  4. New policy => any type

  5. Make sure there is an option all projects in linked groups

  6. Make sure groups dropdown and projects dropdown work

Related to #480637

Merge request reports