Groups scope dropdown loads only linked to SPP groups
What does this MR do and why?
- Extract common logic to
base_items_dropdown.vue
- Update
group_projects_dropdown.vue
to use new base dropdown - Create new
linked_items_dropdown.vue
for loading linked to SPP namespaces and projects - Created tests for new components
- Updated existing tests
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Description | UI |
---|---|
Select only linked to SPP groups | Screen Recording 2024-08-28 at 00.22.18.mov |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
Enable feature flag:
echo "Feature.enable(:policy_group_scope)" | rails c
-
Go to a group
-
Secure -> Policies
-
New policy => any type
-
Make sure there is an option
all projects in linked groups
-
If dropdown is empty, link some groups to same SPP as selected policy
-
Make sure dropdown, contains linked groups
Related to #480637 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @arfedoro
added pipelinetier-1 label
2 Warnings d891a252: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer frontend @thutterer
(UTC+2, same timezone as author)
@ntepluhina
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 216 commits
-
198b1f08...08bea092 - 212 commits from branch
master
- 1dbe9cda - This MR fixes infinite loading for a dropdown
- b5a6283f - initial
- ba61c43a - Initial commit
- 70fcb253 - Applied maintainer review
Toggle commit list-
198b1f08...08bea092 - 212 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c0dab637 and d891a252
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for c0dab637. So we have used data from: 94bd2b32.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerchanged milestone to %17.4
- Resolved by Alexander Turinske
Hey @g.hickman @alan
I have update group scope dropdown to load only linked to SPP groups.
But linked SPP groups query only loads top level group without sub-groups.
We can't explicitly link same SPP to a sub-group, because it is linked automatically:
So right now query loads only top-level groups, explicitly linked to SPP
I think we need to update linkedToSPP query to also load sub-groups, what do you think?
added 145 commits
-
c1811a92...41eea921 - 144 commits from branch
master
- 2e784fa3 - This MR adds linked items dropdown
-
c1811a92...41eea921 - 144 commits from branch
added 340 commits
-
2e784fa3...f013ffd9 - 339 commits from branch
master
- b749c695 - This MR adds linked items dropdown
-
2e784fa3...f013ffd9 - 339 commits from branch
- Resolved by Alexander Turinske
Hey @alan
Could you please test this branch for a policy groups scope?
Since you are backend DRI, I am having following problem:
including groups are loaded for editor but not for a policy list:
I would look into that myself, but it will take longer time for, since it looks like it is a backend issue and this feature is time sensitive
added 232 commits
-
b749c695...fd23ce27 - 229 commits from branch
master
- 4c39ba80 - Update type for linked namespaces
- b4a6cde9 - This MR adds linked items dropdown
- 7e4ca2e9 - Added descendant groups
Toggle commit list-
b749c695...fd23ce27 - 229 commits from branch
- A deleted user
added backend documentation labels
added 175 commits
-
7e4ca2e9...12c9512c - 172 commits from branch
master
- 1dd4ba27 - Update type for linked namespaces
- a675ae2b - This MR adds linked items dropdown
- f6c23e4f - Added descendant groups
Toggle commit list-
7e4ca2e9...12c9512c - 172 commits from branch
added 56 commits
-
f6c23e4f...d31a7ba1 - 52 commits from branch
master
- 42068daa - Update type for linked namespaces
- 64039422 - Applied review changes
- 1128990d - This MR adds linked items dropdown
- b3f9b9e4 - Added descendant groups
Toggle commit list-
f6c23e4f...d31a7ba1 - 52 commits from branch
added 2 commits
mentioned in merge request !164144 (merged)
- Resolved by Alexander Turinske
requested review from @cam.x
added 320 commits
-
7811326f...65044090 - 318 commits from branch
master
- 27aa1bde - This MR adds linked items dropdown
- e697637a - Added descendant groups
-
7811326f...65044090 - 318 commits from branch
added 43 commits
-
e697637a...f43db45a - 41 commits from branch
master
- 4b997d69 - This MR adds linked items dropdown
- f56a0b1b - Added descendant groups
-
e697637a...f43db45a - 41 commits from branch
mentioned in merge request !164946 (merged)
added 869 commits
-
f56a0b1b...10d1dfec - 867 commits from branch
master
- 03a66c19 - This MR adds linked items dropdown
- 0019af3e - Added descendant groups
-
f56a0b1b...10d1dfec - 867 commits from branch
added 15 commits
-
0019af3e...ae7c5f26 - 13 commits from branch
master
- 353885b4 - This MR adds linked items dropdown
- 30a23217 - Added descendant groups
-
0019af3e...ae7c5f26 - 13 commits from branch
- Resolved by Alexander Turinske
requested review from @mcavoj
mentioned in merge request gitlab-com/www-gitlab-com!135589 (merged)
added 9 commits
-
dad7c118...6cef5e10 - 8 commits from branch
master
- 4f01e162 - This MR adds linked items dropdown
-
dad7c118...6cef5e10 - 8 commits from branch
mentioned in issue #485408 (closed)
- Resolved by Martin Čavoj
- Resolved by Martin Čavoj
- Resolved by Martin Čavoj
- Resolved by Martin Čavoj
- Resolved by Martin Čavoj
- Resolved by Alexander Turinske
- Resolved by Martin Čavoj
added 107 commits
-
4f01e162...8f4e7ce2 - 105 commits from branch
master
- 7a265ab3 - This MR adds linked items dropdown
- 8c8ada09 - Applied review changes
-
4f01e162...8f4e7ce2 - 105 commits from branch
requested review from @mcavoj
requested review from @aturinske and removed review request for @mcavoj
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d891a252expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Plan | 74 | 0 | 1 | 0 | 75 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 391 | 0 | 33 | 0 | 424 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for d891a252expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 108 | 0 | 5 | 2 | 113 | ✅ | | Create | 408 | 0 | 51 | 0 | 459 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 516 | 0 | 56 | 2 | 572 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added 266 commits
-
8c8ada09...610eb8e1 - 264 commits from branch
master
- aeeacb13 - This MR adds linked items dropdown
- d891a252 - Applied review changes
-
8c8ada09...610eb8e1 - 264 commits from branch
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
added this merge request to the merge train at position 2
mentioned in commit 32677fdf
added workflowstaging-canary label and removed workflowrefinement label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label