Skip to content
Snippets Groups Projects

Groups scope dropdown loads only linked to SPP groups

Merged Artur Fedorov requested to merge 480637-policies-group-scope-filtered-list into master
All threads resolved!

What does this MR do and why?

  1. Extract common logic to base_items_dropdown.vue
  2. Update group_projects_dropdown.vue to use new base dropdown
  3. Create new linked_items_dropdown.vue for loading linked to SPP namespaces and projects
  4. Created tests for new components
  5. Updated existing tests

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Description UI
Select only linked to SPP groups Screen Recording 2024-08-28 at 00.22.18.mov

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable feature flag:

    echo "Feature.enable(:policy_group_scope)" | rails c
  2. Go to a group

  3. Secure -> Policies

  4. New policy => any type

  5. Make sure there is an option all projects in linked groups

  6. If dropdown is empty, link some groups to same SPP as selected policy

  7. Make sure dropdown, contains linked groups

Related to #480637 (closed)

Edited by Artur Fedorov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Čavoj
  • Martin Čavoj
  • Martin Čavoj
  • Martin Čavoj
  • Martin Čavoj
  • Martin Čavoj
  • Artur Fedorov added 107 commits

    added 107 commits

    Compare with previous version

  • Artur Fedorov requested review from @mcavoj

    requested review from @mcavoj

  • Martin Čavoj requested review from @aturinske and removed review request for @mcavoj

    requested review from @aturinske and removed review request for @mcavoj

  • Martin Čavoj approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for d891a252

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Create      | 128    | 0      | 16      | 0     | 144   | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Plan        | 74     | 0      | 1       | 0     | 75    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 391    | 0      | 33      | 0     | 424   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :white_check_mark: test report for d891a252

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 108    | 0      | 5       | 2     | 113   | ✅     |
    | Create | 408    | 0      | 51      | 0     | 459   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 516    | 0      | 56      | 2     | 572   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Artur Fedorov added 266 commits

    added 266 commits

    Compare with previous version

  • Alexander Turinske
  • Alexander Turinske
  • Alexander Turinske resolved all threads

    resolved all threads

  • Alexander Turinske enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • mentioned in commit 32677fdf

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading