Skip to content

Use separate routes for sign in and sign up

Nicolas Dular requested to merge 20-split-sign-in-and-sign-up into master

What does this MR do?

Part of gitlab-org/growth/engineering#20 (closed)

Currently, the sign in and sign up form is on the same page and can be toggled with a tab bar. Growth wants to start an experiment to have separate pages and also adjust the design of the sign up page.

Changes when feature flag experimental_sign_up_flow is enabled:

  • Instead of users/sign_in#login-pane and users/sign_in#register-pane urls, for the experiment it's users/sign_in and users/sign_up.
  • We redirect to users/sign_up from users/sign_in#register-pane. We're doing this inside <head> on purpose to not render anything from the sign in page beforehand.
  • It removes "Email Confirmation" field, which will hopefully increase conversion.
  • Styling is mostly copied from current login, so we can remove it easier when the experiment is done.
  • We always use the invisible captcha in our experimental sign up flow.

There will be a follow up MR to split the sign up flow into two steps, as proposed in gitlab-org/growth/engineering#20 (closed).

Screenshots

Screenshot_2019-09-18_at_11.50.41

Screenshot_2019-09-18_at_11.50.29

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports