Resolve "Remove RestrictAllowedSchemas.with_suppressed from db/post_migrate/20240209153920_queue_purge_security_scans_with_empty_finding_data.rb"
What does this MR do and why?
While migrating tables to the new gitlab_sec database, we temporarily needed to suppress the restriction of allowed schema during certain migrations where not all tables had yet been transitioned.
This merge request removes the temporary impression of the schema restriction, as it is no longer necessary following the completion of the table migrations.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #477986 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @schmil.monderer
added 1 commit
- b78957a7 - Remove RestrictAllowedSchemas.with_suppressed
added pipeline:run-all-rspec label
- A deleted user
added databasereview pending label
3 Warnings 2cc75c6b: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer database @jdrpereira
(UTC+1, 1 hour behind author)
@OmarQunsulGitlab
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Omar Qunsul
@jdrpereira could you do the initial database review?
requested review from @jdrpereira
added pipeline:mr-approved label
added pipelinetier-2 label
added databasereviewed label and removed databasereview pending label
requested review from @OmarQunsulGitlab
added databaseapproved label and removed databasereviewed label