Skip to content

Handle membership access requests for indirect members

Lee Tickett requested to merge gitlab-community/gitlab:480546-access-requests-for-indirect-members into master

What does this MR do and why?

Related to #480546 (closed)

This merge request handles access requests for existing indirect members by displaying a "you already have access" message rather than returning a 403 error.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screen_Recording_2024-08-28_at_21.49.50 Screen_Recording_2024-08-28_at_21.48.40

How to set up and validate locally

  1. Create 2 groups (a and b)
  2. Add a user to group a
  3. Invite group a as a member to group b
  4. Impersonate the user and request access to group b (http://gdk.local:3000/groups/b/-/group_members/request_access)

You should get a 403 on master, but a message you already have access on this branch 🤞

Merge request reports