Move Receptive Agents feature to Ultimate
What does this MR do and why?
This MR moves all the Receptive Agents features to Ultimate.
The Receptive Agents features have been introduced in the context of Support clusters that can't see GitLab (&12180) and NOT been released yet. It's also a feature that is NOT available on GitLab.com.
Thus, it's okay to move it to Ultimate.
I'm not sure if it actually makes sense to split into multiple MRs or if it's "simple" enough to review since there is just a pattern of moving files and adding license checks.
Closes #481418 (closed)
Merge request reports
Activity
assigned to @timofurrer
changed milestone to %17.4
added pipelinetier-1 label
- A deleted user
added documentation frontend labels
- Resolved by Timo Furrer
- Resolved by Timo Furrer
4 Warnings 28a6b096: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 072d7a0b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 6bc2ebfd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/cluster_agents.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @hmerscher
(UTC+2, same timezone as author)
@seanarnold
(UTC+12, 10 hours ahead of author)
frontend @bsandlin
(UTC-5, 7 hours behind author)
@tbulva
(UTC+2, same timezone as author)
groupauthorization Reviewer review is optional for groupauthorization @pslaughter
(UTC-5, 7 hours behind author)
groupauthorization Reviewer review is optional for groupauthorization @alexbuijs
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger -
added 1 commit
- 8390d61e - Move Receptive Agents Application Setting to EE
added 1 commit
- a1357fac - Move Receptive Agents Application Setting to EE
added 1 commit
- 39d15ddb - Move Receptive Agents Application Setting to EE
added workflowin review label and removed workflowin dev label
requested review from @panoskanell and @marina.mosti
removed review request for @panoskanell
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 50021437expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 32 | 0 | 420 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @hmehra
requested review from @lorenzvanherwaarden
removed review request for @marina.mosti
reset approvals from @lorenzvanherwaarden by pushing to the branch
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7705528370 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 75.65 s < 27.12 s #7718160453 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 77.32 s < 27.12 s #7737844965 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 70.96 s < 27.12 s - A deleted user
added rspec:slow test detected label
mentioned in merge request !164719 (merged)
added 733 commits
-
10ab01ee...f66cf49a - 718 commits from branch
master
- f66cf49a...83a72611 - 5 earlier commits
- b5bc0361 - Move cluster agent URL configuration services to EE
- a35974c3 - Protect Receptive Agents services with feature checks
- 7a39e87e - Move Receptive Agents entities to EE
- 6bc2ebfd - Move Receptive Agents internal REST API to EE
- 072d7a0b - Move Receptive Agents GraphQL API into EE
- ee0afbf9 - Move Receptive Agents is_receptive API entity field to EE
- 5cbce1f4 - Move Receptive Agents URL config model into EE
- 803a596a - Move Receptive Agents URL config relationship to EE
- 28a6b096 - Move Receptive Agents Application Setting to EE
- 50021437 - Moving HostValidator back to EE
Toggle commit list-
10ab01ee...f66cf49a - 718 commits from branch
requested review from @DylanGriffith
removed review request for @DylanGriffith
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
- Resolved by Timo Furrer
started a merge train
mentioned in commit 0ae0014f
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8264 (closed)
mentioned in merge request !164987 (merged)
1 # frozen_string_literal: true 2 3 require 'spec_helper' 4 5 RSpec.describe GitlabSchema.types['ClusterAgent'], feature_category: :deployment_management do # rubocop:disable RSpec/DuplicateSpecLocation -- EE spec This caused master broken: gitlab-org/quality/engineering-productivity/master-broken-incidents#8264 (closed)
We should not disable this cop rule. See #482856 (closed)
My bad @splattael. Thanks for the fix
For posterity: I've fixed the "disable cop rule" with Consolidate EE cluster agent type specs (!165001 - merged). Thanks Peter for creating the issues on following up on this
mentioned in issue #482856 (closed)
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label