Remember user preference for showing labels on work item widgets
What does this MR do and why?
Remember what the user's preference was for showing or hiding labels on
- Work item tree (children)
- Work item Relationships (Linked items)
- Work item links (Task list on an issue)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Area | Before | After |
---|---|---|
Task list on issue | Screen_Recording_2024-08-23_at_17.41.38 | Screen_Recording_2024-08-23_at_17.40.38 |
Work item "Child items" list | Screen_Recording_2024-08-23_at_17.42.22 | Screen_Recording_2024-08-23_at_17.38.46 |
Work item "Linked items" list | Screen_Recording_2024-08-23_at_17.43.04 | Screen_Recording_2024-08-23_at_17.39.41 |
How to set up and validate locally
- Check out this branch
- Visit an issue in the GDK that has tasks (or add tasks to an existing issue)
- Make sure that at least one of the tasks has a label applied to it
- On the issue page, in the "Child items" section turn off the "Show labels" preference
- The labels will stop showing
- Refresh the page. The labels will not show once the page loads, and the "Show labels" preference toggle will be in the off position.
- Toggle the "Show labels" setting back on and refresh the page
- You will see that the labels show again on page load.
- Ensure you are using the epic work items feature flag
- Navigate to or create an epic that has at least one child epic
- Make sure that at least one of the child epics has a label applied to it
- In the "Child items" of the epic that has at least one child item with a label on it, toggle off the "Show labels" preference
- The labels will stop showing on child items
- Refresh the page. The labels will not show once the page loads, and the "Show labels" preference toggle will be in the off position.
- Toggle the "Show labels" setting back on and refresh the page
- You will see that the labels show again on page load.
- Link an issue that has at least one label applied to it to the epic in the "Linked items" section
- Turn off the "Show labels" preference for the Linked items section
- Refresh the page. The labels will not show once the page loads, and the "Show labels" preference toggle will be in the off position.
- Toggle the "Show labels" setting back on and refresh the page
- You will see that the labels show again on page load.
Related to #478618 (closed), #469616 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @clavimoniere
changed milestone to %17.4
added pipelinetier-1 label
removed pipelinetier-1 label
4 Warnings 92e2f0fc: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. a1cea341: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer frontend @mcavoj
(UTC+2, 6 hours ahead of author)
@tbulva
(UTC+2, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Chad Lavimoniere
@nickbrandt @nickleonard I want to make sure this is in line with your design expectations here.
What I've gone for here is remembering this preference for all work items, not just the single one you were looking at. So for example, if I'm looking at Epic A and I turn off "Show labels" on the child items list, that preference will be remembered when I look at Epic B, C, etc. Same with showing/hiding labels on linked items across all work items, and same with showing/hiding labels on the tasks shown in the child items section on all legacy issuables.
- Resolved by Tomas Bulva
requested review from @ramistry
- Resolved by Chad Lavimoniere
added pipeline:mr-approved label
added pipelinetier-2 label
added 605 commits
-
f595ae84...1a3dc66e - 604 commits from branch
master
- ed43b9bd - Merge branch 'master' into...
-
f595ae84...1a3dc66e - 604 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a3810e6c and 92e2f0fc
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.33 MB 4.33 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for a3810e6c. So we have used data from: 2bda758d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 92e2f0fcexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 32 | 0 | 420 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 92e2f0fcexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 270 | 0 | 36 | 0 | 306 | ✅ | | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 352 | 0 | 45 | 0 | 397 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
removed review request for @tbulva
added 284 commits
-
ed43b9bd...5ab9128f - 283 commits from branch
master
- ae5b88c4 - Merge branch 'master' into...
-
ed43b9bd...5ab9128f - 283 commits from branch
requested review from @tbulva
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7699707378 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 51.52 s < 50.13 s #7730705117 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 53.58 s < 50.13 s - A deleted user
added rspec:slow test detected label
removed review request for @tbulva
requested review from @tbulva
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @tbulva
removed pipeline:run-e2e-omnibus-once label
added this merge request to the merge train at position 2
mentioned in commit 4b6003bf
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8236 (closed)
added workflowstaging-canary label and removed workflowplanning breakdown label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label