Skip to content
Snippets Groups Projects

Add Duo chat sub-feature to Backend self-hosted models settings

Merged Patrick Cyiza requested to merge 473005-be-self-hosted-model-per-duo-tool-sub-feature into master
All threads resolved!

What does this MR do and why?

It adds Duo-chat sub-feature to the backend of the self-hosted model's feature settings. They can now be configured individually.

Users must be able to configure each of their supported models (previously declared to GitLab) to specific Duo features and sub-features.

It also introduces the FF ai_duo_chat_sub_features_settings to hide the untest configurations.

See design issue #469612 (closed).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

run the tests bundle exec rspec ee/spec/lib/gitlab/llm/chain/requests/ai_gateway_spec.rb

Related to #473005 (closed) Blocks #476660 (closed)

Edited by Patrick Cyiza

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Patrick Cyiza added 1 commit

    added 1 commit

    • 3c5ed290 - Implement ai_duo_chat_sub_features_settings FF

    Compare with previous version

  • A deleted user added feature flag label

    added feature flag label

  • Patrick Cyiza added 1 commit

    added 1 commit

    • 45a864cf - Fix enum number in Ai::FeatureSetting

    Compare with previous version

  • Patrick Cyiza changed the description

    changed the description

  • Patrick Cyiza mentioned in issue #480893

    mentioned in issue #480893

  • Patrick Cyiza added 1 commit

    added 1 commit

    • f85dbf55 - Update ai_duo_chat_sub_features_settings.yml with rollout issue

    Compare with previous version

  • Patrick Cyiza added 1 commit

    added 1 commit

    • 872b0cfe - Fix feature_setting_spec.rb flagged_features class method unit test

    Compare with previous version

  • Patrick Cyiza marked this merge request as ready

    marked this merge request as ready

  • mentioned in issue #473005 (closed)

  • Patrick Cyiza requested review from @mhamda and removed review request for @igor.drozdov

    requested review from @mhamda and removed review request for @igor.drozdov

  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda
  • Mohamed Hamda approved this merge request

    approved this merge request

  • Patrick Cyiza added 1 commit

    added 1 commit

    • e5440c16 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Patrick Cyiza reset approvals from @mhamda by pushing to the branch

    reset approvals from @mhamda by pushing to the branch

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 0f8428cf

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Package     | 40     | 0      | 21      | 0     | 61    | ✅     |
    | Verify      | 84     | 0      | 4       | 0     | 88    | ✅     |
    | Plan        | 143    | 0      | 0       | 0     | 143   | ✅     |
    | Create      | 243    | 0      | 31      | 0     | 274   | ✅     |
    | Govern      | 136    | 0      | 0       | 0     | 136   | ✅     |
    | Release     | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Fulfillment | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 61     | 0      | 2       | 0     | 63    | ✅     |
    | Monitor     | 16     | 0      | 0       | 0     | 16    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage      | 2      | 0      | 2       | 0     | 4     | ✅     |
    | Secure      | 6      | 0      | 0       | 0     | 6     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 749    | 0      | 60      | 0     | 809   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for e5440c16

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 162    | 0      | 18      | 0     | 180   | ✅     |
    | Package     | 48     | 0      | 28      | 0     | 76    | ✅     |
    | Verify      | 102    | 0      | 30      | 0     | 132   | ✅     |
    | Create      | 538    | 0      | 68      | 0     | 606   | ✅     |
    | Data Stores | 66     | 0      | 20      | 0     | 86    | ✅     |
    | Govern      | 162    | 0      | 10      | 6     | 172   | ✅     |
    | Monitor     | 16     | 0      | 24      | 0     | 40    | ✅     |
    | Manage      | 4      | 0      | 16      | 0     | 20    | ✅     |
    | Configure   | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Release     | 10     | 0      | 2       | 0     | 12    | ✅     |
    | Secure      | 8      | 0      | 4       | 2     | 12    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Fulfillment | 4      | 0      | 14      | 0     | 18    | ✅     |
    | Growth      | 0      | 0      | 4       | 0     | 4     | ➖     |
    | ModelOps    | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Ai-powered  | 0      | 0      | 4       | 0     | 4     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 1124   | 0      | 250     | 8     | 1374  | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Patrick Cyiza added 1 commit

    added 1 commit

    • 66512960 - Limite use unit_primitive in Gitlab::Llm::Chain::Requests::AiGateway

    Compare with previous version

  • Author Maintainer

    Hey @mksionek could you maintainerize this MR please :pray_tone5:!

  • Patrick Cyiza requested review from @mksionek

    requested review from @mksionek

  • Mohamed Hamda approved this merge request

    approved this merge request

  • Mohamed Hamda removed review request for @mhamda

    removed review request for @mhamda

  • Gosia Ksionek
  • Patrick Cyiza added 1 commit

    added 1 commit

    • f9a1a0a5 - Rename Ai::FeatureSetting.allowed_features

    Compare with previous version

  • Patrick Cyiza reset approvals from @mhamda by pushing to the branch

    reset approvals from @mhamda by pushing to the branch

  • Patrick Cyiza requested review from @mksionek

    requested review from @mksionek

  • Gosia Ksionek
  • Patrick Cyiza added 1 commit

    added 1 commit

    • 0f8428cf - Flag duo_chat as a stable feature for self hosted

    Compare with previous version

  • Gosia Ksionek resolved all threads

    resolved all threads

  • Gosia Ksionek approved this merge request

    approved this merge request

  • Gosia Ksionek enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Gosia Ksionek added this merge request to the merge train at position 7

    added this merge request to the merge train at position 7

  • Gosia Ksionek mentioned in commit 42e5639a

    mentioned in commit 42e5639a

  • Igor Drozdov mentioned in merge request !165009 (merged)

    mentioned in merge request !165009 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Sean Carroll mentioned in issue #502740

    mentioned in issue #502740

  • Please register or sign in to reply
    Loading