Pages unique domain url update
What does this MR do and why?
We have updated the Pages unique domain url creating logic: <Project_name> + random 6 digit hex
Before saving, we are validating if the domain url is already assigned to another project or not.
Related: #441215 (closed)
Changelog: fixed
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.4
added Category:Pages bugfunctional typebug labels
assigned to @ngala
added devopsplan groupknowledge sectiondev labels
added pipelinetier-1 label
- A deleted user
added backend label
3 Warnings 276758fe: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 276758fe: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 6966627e: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Category Reviewer Maintainer backend @OmarQunsulGitlab
(UTC+2, 3.5 hours behind author)
@stanhu
(UTC-7, 12.5 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 5 commits
-
64519cce...a48e4f03 - 4 commits from branch
master
- 2370c00c - Pages unique domain url update
-
64519cce...a48e4f03 - 4 commits from branch
- A deleted user
added databasereview pending label
@janis As you have the most context, can you please review this change? Thank you.
Edited by Naman Jagdish Galaadded workflowready for review label
requested review from @janis
mentioned in issue #441215 (closed)
- Resolved by Naman Jagdish Gala
@ngala Thank you soo much for this! Just one non-blocking comment!
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 905c587dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 31 | 0 | 419 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 6966627eexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 352 | 0 | 43 | 0 | 395 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
reset approvals from @janis by pushing to the branch
- Resolved by Vladimir Shushlin
@vshushlin Can you please perform maintainer review for this change? Thank you.
added workflowin review label and removed workflowready for review label
requested review from @vshushlin
removed pipeline:run-e2e-omnibus-once label
removed review request for @janis
- Resolved by Vladimir Shushlin
removed review request for @vshushlin
reset approvals from @janis by pushing to the branch
requested review from @vshushlin
- Resolved by Vladimir Shushlin
- Resolved by Vladimir Shushlin
Thanks, @ngala! One more suggestion
removed review request for @vshushlin
requested review from @vshushlin
- Resolved by Vladimir Shushlin
- Resolved by Vladimir Shushlin
Thanks, @ngala!
One tiny comment, otherwise LGTM
removed review request for @vshushlin
requested review from @vshushlin
Thanks, @ngala! LGTM
started a merge train
mentioned in commit 3d16374f
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !172479 (merged)