Skip to content
Snippets Groups Projects

Pages unique domain url update

Merged Naman Jagdish Gala requested to merge ngala/pages-unique-domain into master
All threads resolved!

What does this MR do and why?

We have updated the Pages unique domain url creating logic: <Project_name> + random 6 digit hex

Before saving, we are validating if the domain url is already assigned to another project or not.

Related: #441215 (closed)

Changelog: fixed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Naman Jagdish Gala

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @ngala Thank you soo much for this! Just one non-blocking comment!

  • Janis Altherr approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 905c587d

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Create      | 128    | 0      | 15      | 0     | 143   | ✅     |
    | Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 388    | 0      | 31      | 0     | 419   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 6966627e

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Plan   | 82     | 0      | 9       | 0     | 91    | ✅     |
    | Create | 270    | 0      | 34      | 0     | 304   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 352    | 0      | 43      | 0     | 395   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
  • added 1 commit

    Compare with previous version

  • Naman Jagdish Gala reset approvals from @janis by pushing to the branch

    reset approvals from @janis by pushing to the branch

  • requested review from @vshushlin

  • added 1 commit

    Compare with previous version

  • Janis Altherr approved this merge request

    approved this merge request

  • Janis Altherr removed review request for @janis

    removed review request for @janis

  • Vladimir Shushlin removed review request for @vshushlin

    removed review request for @vshushlin

  • added 1 commit

    Compare with previous version

  • Naman Jagdish Gala reset approvals from @janis by pushing to the branch

    reset approvals from @janis by pushing to the branch

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 96c0d43c - Loop max 10 times and raise error

    Compare with previous version

  • added 1 commit

    • e2dfff62 - Loop max 10 times and raise error

    Compare with previous version

  • requested review from @vshushlin

  • added 1 commit

    • 516cbfd3 - Loop max 10 times and raise error

    Compare with previous version

  • Vladimir Shushlin removed review request for @vshushlin

    removed review request for @vshushlin

  • added 1 commit

    Compare with previous version

  • requested review from @vshushlin

  • added 1 commit

    Compare with previous version

  • Vladimir Shushlin resolved all threads

    resolved all threads

  • Vladimir Shushlin removed review request for @vshushlin

    removed review request for @vshushlin

  • added 1 commit

    Compare with previous version

  • requested review from @vshushlin

  • Vladimir Shushlin resolved all threads

    resolved all threads

  • Vladimir Shushlin enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • Thanks, @ngala! LGTM :rocket:

  • mentioned in commit 3d16374f

  • added workflowstaging label and removed workflowcanary label

  • Ben King mentioned in merge request !172479 (merged)

    mentioned in merge request !172479 (merged)

  • Please register or sign in to reply
    Loading