Skip to content

Fix issue when resizing images in RTE

Himanshu Kapoor requested to merge himkp-image-resize-17-3 into 17-3-stable-ee

What does this MR do and why?

When resizing images, we get dimensions from the DOM to begin resize. But if the dimensions are "auto", doing a parseInt on them results in NaN. In that case we should fall back to computed values of width and height.

MR against master: !163382 (merged)

It was a regression from !161676 (merged) which was released in 17.3.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stanislav Lashmanov

Merge request reports