Backport 'Turn NotFound from Gitaly into 404 for InfoRefs' into 17.3
What does this MR do and why?
This MR backports Turn NotFound from Gitaly into 404 for InfoRefs (!162697 - merged) into %17.3.
Related:
- Turn NotFound from Gitaly into 404 for InfoRefs (!162697 - merged)
- Workhorse returns 500 when Gitaly returns NotFo... (#478907 - closed)
- https://gitlab.com/gitlab-org/release/tasks/-/issues/12583+
- https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/incident-management/-/issues/349+
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
changed milestone to %17.3
assigned to @ashmckenzie
mentioned in issue #478907 (closed)
added severity2 label
1 Warning The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.Reviewer roulette
Category Reviewer Maintainer workhorse @ghinfey
(UTC+1, 9 hours behind author)
No maintainer available Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
QA
e2e:package-and-test-ee
@ashmckenzie, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#test-platform
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %17.4
added missed:17.3 label
changed milestone to %17.3
removed missed:17.3 label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3566c262expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 379 | 0 | 31 | 0 | 410 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3566c262expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Package | 28 | 0 | 17 | 1 | 45 | ✅ | | Govern | 106 | 1 | 6 | 0 | 113 | ❌ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Manage | 28 | 0 | 17 | 0 | 45 | ✅ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | Create | 417 | 0 | 51 | 0 | 468 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Verify | 51 | 0 | 15 | 0 | 66 | ✅ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Data Stores | 46 | 0 | 11 | 0 | 57 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Secure | 4 | 0 | 2 | 1 | 6 | ✅ | | Ai-powered | 1 | 0 | 2 | 0 | 3 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 797 | 1 | 158 | 2 | 956 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
- Resolved by Ash McKenzie
@ashmckenzie Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1415597620
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#test-platform
Slack channel. -
changed milestone to %17.4
added missed:17.3 label
changed milestone to %17.3
mentioned in issue #478821
changed milestone to %17.4
mentioned in issue gitlab-org/quality/pipeline-triage#285 (closed)
changed milestone to %17.3
removed missed:17.3 label
mentioned in issue gitlab-org/quality/pipeline-triage#286 (closed)