Tests - Update groups fabrication via UI
What does this MR do and why?
Search field was removed for dashboard/groups
page in case there are no groups, aka 'empty state' - !162034 (merged).
This MR is to update the tests to handle empty state for dashboard/groups
properly. Essentially return false
for has_group?
method when a user has no groups.
This should fix the following tests that we see failing on Staging:
- https://gitlab.com/gitlab-org/gitlab/-/issues/478450
- https://gitlab.com/gitlab-org/gitlab/-/issues/478451
- https://gitlab.com/gitlab-org/gitlab/-/issues/478462
- https://gitlab.com/gitlab-org/gitlab/-/issues/478452
- https://gitlab.com/gitlab-org/gitlab/-/issues/478446
- https://gitlab.com/gitlab-org/gitlab/-/issues/478447
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Tests that were failing before are passing locally when run against Staging:
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Run the tests agains Staging, e.g. (Make sure to set GITLAB_QA_USER_AGENT, GITLAB_ADMIN_USERNAME, GITLAB_ADMIN_PASSWORD, GITLAB_QA_ADMIN_ACCESS_TOKEN env variables):
QA_GITLAB_URL=https://staging.gitlab.com bundle exec rspec qa/specs/features/ee/browser_ui/11_fulfillment/saas_user_limit_experience_spec.rb
Merge request reports
Activity
assigned to @ichernikov
changed milestone to %17.4
added typemaintenance label
added pipelinetier-1 label
- A deleted user
added QA label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer QA @willmeek
(UTC+1, same timezone as author)
@a_mcdonald
(UTC+12, 11 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded Quality label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3ae535a2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Package | 16 | 0 | 12 | 0 | 28 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 379 | 0 | 28 | 0 | 407 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3ae535a2expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Create | 412 | 0 | 51 | 0 | 463 | ✅ | | Govern | 107 | 0 | 6 | 0 | 113 | ✅ | | Data Stores | 46 | 0 | 11 | 0 | 57 | ✅ | | Manage | 28 | 0 | 17 | 0 | 45 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Package | 31 | 0 | 14 | 1 | 45 | ✅ | | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Secure | 4 | 0 | 2 | 1 | 6 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Verify | 51 | 0 | 15 | 0 | 66 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 795 | 0 | 155 | 2 | 950 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-org/quality/pipeline-triage#284 (closed)
Thanks @ichernikov for the quick fix! LGTM
FYI, I triggered a pipeline against Staging using the gitlab-qa image built in this MR:-
https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/15027909
-
https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/15027912
- This one is fine I think since the failure is addressed here !162731 (merged) and it happened after it had gotten passed creating sandbox group step.
See doc for more info on how to https://gitlab.com/gitlab-org/quality/runbooks/-/blob/main/running-tests-in-environments/staging.md?ref_type=heads#from-an-mr
cc @jmiocene - FYI since it was caused by !162034 (merged) . We didn't see these failure until the change hit Staging because these tests were setup to only run in Staging.
-
https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/15027909
requested review from @treagitlab
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 857f1962
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label