Skip to content
Snippets Groups Projects

Hide search panel when user has no groups

Merged Julia Miocene requested to merge group-empty-state-jmiocene into master
All threads resolved!

What does this MR do and why?

Hide search panel when user has no groups

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
1_before 1_after
2_before 2_after

How to set up and validate locally

Test user that can create groups

  1. Go to http://gdk.test:3000/admin/users
  2. Open the user with no groups
  3. Click [Impersonate]
  4. Go to http://gdk.test:3000/dashboard/groups

Test user with no permission

  1. Go to http://gdk.test:3000/admin/users
  2. Open the user with no groups
  3. Click [Edit]
  4. Opt-out Can create top level group
  5. Save
  6. Click [Impersonate]
  7. Go to http://gdk.test:3000/dashboard/groups

#442898 (closed) #452231 (closed)

Edited by Julia Miocene

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Max Orefice
  • Julia Miocene added 1 commit

    added 1 commit

    Compare with previous version

  • Max Orefice approved this merge request

    approved this merge request

  • Max Orefice requested review from @garyh

    requested review from @garyh

  • Max Orefice removed review request for @morefice

    removed review request for @morefice

  • Julia Miocene added 335 commits

    added 335 commits

    Compare with previous version

  • Security policy violations have been resolved.

    Edited by GitLab Security Bot
  • Julia Miocene added 215 commits

    added 215 commits

    Compare with previous version

  • Kos Palchyk
  • Kos Palchyk
  • Kos Palchyk approved this merge request

    approved this merge request

  • requested review from @anna_vovchenko

    • Resolved by Anna Vovchenko

      note: I'm sorry to be double-cautious here. I see that we had issues with QA tests before with similar changes, that were late discovered due to some nuances in the way QA tasks are run.

      And I'm not super aware of the test flows, and I'm not sure if anything has changed with predictable QA tests after that case. Anyhow, as recommended, let's ensure that the e2e:package-and-test job is run before the merge.

      Also, afaiu, some specs are only executed on staging, but I don't know the details for this. We do have an id for the "new button", but the filter field, mentioned in the linked comment is now gone. That is what concerns me. Just to be double-sure: @morefice, could you explicitly confirm that we have that side covered? Sorry for the extra ping and for being overly cautious.

  • Gary Holtz approved this merge request

    approved this merge request

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Anna Vovchenko mentioned in commit 04089aa3

    mentioned in commit 04089aa3

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #442898 (closed)

  • Ievgen Chernikov mentioned in merge request !162866 (merged)

    mentioned in merge request !162866 (merged)

  • Please register or sign in to reply
    Loading