Hide search panel when user has no groups
What does this MR do and why?
Hide search panel when user has no groups
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Test user that can create groups
- Go to http://gdk.test:3000/admin/users
- Open the user with no groups
- Click [Impersonate]
- Go to http://gdk.test:3000/dashboard/groups
Test user with no permission
- Go to http://gdk.test:3000/admin/users
- Open the user with no groups
- Click [Edit]
- Opt-out
Can create top level group
- Save
- Click [Impersonate]
- Go to http://gdk.test:3000/dashboard/groups
Merge request reports
Activity
changed milestone to %17.3
added UX Paper Cuts grouptenant scale typemaintenance labels
assigned to @jmiocene
added pipelinetier-1 label
added devopsdata stores sectioncore platform labels
- Resolved by Julia Miocene
Hey @seggenberger
Could you please review UX here?
requested review from @seggenberger
2 Warnings a912f152: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/dashboard/groups/index.html.haml
+%div{ data: { testid: 'groups-page' } } + primary_button_options: { data: { testid: "new-group-button" } }, + empty_state_options: { data: { testid: 'groups-empty-state' } }) do |c|
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @morefice
(UTC+2, same timezone as author)
@garyh
(UTC-5, 7 hours behind author)
frontend @kpalchyk
(UTC+3, 1 hour ahead of author)
@anna_vovchenko
(UTC+3, 1 hour ahead of author)
test for spec/features/*
@morefice
(UTC+2, same timezone as author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Julia Miocene
@jmiocene Should we really remove the page header and move the buttons? We just invested into aligning these pages more, so I want to make sure that this would be consistent across the product.
/cc @mnichols1
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @seggenberger
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a912f152expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 379 | 0 | 31 | 0 | 410 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for a912f152expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Manage | 26 | 2 | 17 | 1 | 45 | ❌ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Create | 417 | 0 | 51 | 0 | 468 | ✅ | | Govern | 106 | 0 | 7 | 0 | 113 | ✅ | | Verify | 51 | 0 | 15 | 0 | 66 | ✅ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Data Stores | 46 | 0 | 11 | 0 | 57 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Secure | 4 | 0 | 2 | 1 | 6 | ✅ | | Package | 28 | 0 | 17 | 1 | 45 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Ai-powered | 1 | 0 | 2 | 0 | 3 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 795 | 2 | 159 | 3 | 956 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
- Resolved by Anna Vovchenko
requested review from @morefice
- Resolved by Anna Vovchenko
requested review from @kpalchyk
- Resolved by Julia Miocene
- Resolved by Julia Miocene
requested review from @garyh
removed review request for @morefice
added 335 commits
-
0238d75e...995bda2d - 333 commits from branch
master
- 573a3934 - Hide search panel when user has no groups
- d0a5107d - Apply suggestions
-
0238d75e...995bda2d - 333 commits from branch
mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#967 (closed)
Security policy violations have been resolved.
Edited by GitLab Security Botadded 215 commits
-
d0a5107d...2048f171 - 213 commits from branch
master
- 9508d0db - Hide search panel when user has no groups
- a912f152 - Apply suggestions
-
d0a5107d...2048f171 - 213 commits from branch
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
requested review from @anna_vovchenko
- Resolved by Anna Vovchenko
note: I'm sorry to be double-cautious here. I see that we had issues with QA tests before with similar changes, that were late discovered due to some nuances in the way QA tasks are run.
And I'm not super aware of the test flows, and I'm not sure if anything has changed with predictable QA tests after that case. Anyhow, as recommended, let's ensure that the
e2e:package-and-test
job is run before the merge.Also, afaiu, some specs are only executed on staging, but I don't know the details for this. We do have an id for the "new button", but the filter field, mentioned in the linked comment is now gone. That is what concerns me. Just to be double-sure: @morefice, could you explicitly confirm that we have that side covered? Sorry for the extra ping and for being overly cautious.
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 04089aa3
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#7971 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-org/quality/pipeline-triage#284 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in issue #442898 (closed)
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3241 (merged)
mentioned in merge request !162866 (merged)