Work item rolled up count by type
What does this MR do and why?
Work item rolled up count by type in work items
- Show work item rolled up count by type as a badge in header
- Show the work item rolled up count by type as details in children
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Use case | screenshot |
---|---|
Header with rolled up count by type |
![]() |
Child metadata rolled up count by type |
![]() |
Modal header rolled up count by type |
![]() |
No children information in header |
![]() |
Objective roll up data |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to any work item with hierarchy (objective/epic)
- Associate different kinds of work items in the tree
- See that the rollup count is visible
Related to #474913 (closed)
Resolves #478622 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @deepika.guliani
added pipelinetier-1 label
3 Warnings This merge request is quite big (570 lines changed), please consider splitting it into multiple merge requests. 29812272: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.1 Message This merge request includes changes to Vue files that have both CE and EE versions. Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/work_items/components/shared/work_item_link_child_metadata.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/work_items/components/work_item_links/work_item_rolled_up_count.vue
+ data-testid="work-item-rolled-up-detailed-count" + data-testid="work-item-rolled-up-badge-count" + data-testid="detailed-popover" + data-testid="badge-popover" + data-testid="badge-warning"
app/assets/javascripts/work_items/components/work_item_links/work_item_rolled_up_count_info.vue
+ data-testid="rolled-up-count-info" + data-testid="rolled-up-type-info"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @minahilnichols
(UTC-4, 9.5 hours behind author)
@xanf
(UTC+3, 2.5 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 103 commits
-
bc64ed62...60e6ba61 - 102 commits from branch
master
- ac3dc24b - Work item rollupcount by type
-
bc64ed62...60e6ba61 - 102 commits from branch
removed backend label
mentioned in task #478622 (closed)
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7571572184 ee/spec/features/groups/work_items/work_item_spec.rb#L41
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when updating child work item dates rolled up child dates 104.8 s < 50.13 s #7650368770 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 51.11 s < 50.13 s #7663847784 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 62.05 s < 50.13 s #7708919418 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 52.61 s < 50.13 s #7717372600 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 51.96 s < 50.13 s #7741079695 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 55.08 s < 50.13 s #7743326142 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 52.15 s < 50.13 s #7753922936 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 53.12 s < 50.13 s - A deleted user
added rspec:slow test detected label
- Resolved by Deepika Guliani
- Resolved by Deepika Guliani
added 169 commits
-
ac3dc24b...9da12fdd - 166 commits from branch
master
- 6b26b4ce - Work item rollupcount by type
- cedc4adf - Add backend logic
- e99e8203 - Better icon handling
Toggle commit list-
ac3dc24b...9da12fdd - 166 commits from branch
- A deleted user
added backend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits eec784e7 and 29812272
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for eec784e7. So we have used data from: 6bacbd1c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request !162597 (merged)
added 1428 commits
-
e99e8203...e2633907 - 1425 commits from branch
master
- 73a0d4fc - Show actual descendant counts in hierarchy widget
- 06f50e39 - Work item rollupcount by type
- c2135474 - Better icon handling
Toggle commit list-
e99e8203...e2633907 - 1425 commits from branch
removed workflowplanning breakdown label
@deepika.guliani I rebased this branch onto the latest backend. The backend MR is now in review.
- Resolved by Deepika Guliani
@nickleonard @nickbrandt Hey
Can you please review this MR ? ( Anyone of you can review , just wanted to make sure you both know how it looks )
requested review from @nickbrandt and @nickleonard
removed review request for @nickleonard
requested review from @nickleonard
removed review request for @nickleonard
mentioned in issue #474913 (closed)
mentioned in merge request !164306 (merged)
added 1151 commits
-
2075dec2...4e362bcd - 1148 commits from branch
master
- bc317412 - Work item rollupcount by type
- 7f2a142c - Rollup count position in header
- b6f83b6e - Apply UX comments
Toggle commit list-
2075dec2...4e362bcd - 1148 commits from branch