Skip to content
Snippets Groups Projects

Resolve "Add more whitespace to Merge Topics Modal"

Merged Vanessa Otto requested to merge 477254-add-more-whitespace-to-merge-topics-modal into master

What does this MR do and why?

  1. Frontend Refactoring: Replace programmatic .submit() call after emitted event with native type="submit" button handling
  2. UI Bugfix: Replaces div with gl-form-group to apply automatic spacings.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-08-05_at_15.28.59 Screenshot_2024-08-05_at_16.30.34

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. As an admin, go to http://gdk.test:3000/admin/topics
  2. If there are no topics, create two topics
  3. Open the modal "Merge topics"
  4. Select two different topics

Closes #477254 (closed)

Edited by Vanessa Otto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading