Skip to content

Delete the `emoji_webhooks` feature flag

Dylan Griffith requested to merge delete-old-feature-flags-emoji_webhooks into master

This feature flag was introduced in 16.2, which is more than 12 milestones ago.

As part of our process we want to ensure feature flags don't stay too long in the codebase.

Rollout issue: #417288

The feature flag is enabled by default. Unless it's disabled on GitLab.com, you should keep the feature-flag code branch, otherwise, keep the other branch.

Remaining mentions of the feature flag (click to expand)
CHANGELOG.md
8959:- [Enable emoji_webhooks feature flag by default](gitlab-org/gitlab@b241017131a40ad01a286987b3c5c6cbced8ec38) ([merge request](gitlab-org/gitlab!128861))

spec/models/projects/triggered_hooks_spec.rb
63:    context 'when emoji_webhooks feature flag is disabled' do
65:        stub_feature_flags(emoji_webhooks: false)

It is possible that this MR will still need some changes to remove references to the feature flag in the code. At the moment the gitlab-housekeeper is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues. It is the responsibility of groupimport and integrate to push those changes to this branch. If they are already removing this feature flag in another merge request then they can just close this merge request.

You can also see the status of the rollout by checking #417288 and https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=emoji_webhooks&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com.

This change was generated by gitlab-housekeeper using the Keeps::DeleteOldFeatureFlags keep.

To provide feedback on your experience with gitlab-housekeeper please create an issue with the label GitLab Housekeeper and consider pinging the author of this keep.

Edited by Dylan Griffith

Merge request reports