Add jh spec features folder in qa runner for JH edition
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
JH QA team retrying to enable retry failed qa test however we found it is not working, job link.
After analyze we found
-
examples.txtfile, which contains failed test info, is generated when qa test run first time -
when retry failed test runs, rspec shows
All examples were filtered out, which means rspec didn't load correct specs -
when retry failed test runs, rspec accept params like
--only-failuresand disableknapsack, then spec runner load folderqa/qa/specs/featuresas tests, because runner code below# qa/qa/specs/runner.rb DEFAULT_TEST_PATH_ARGS = ['--', File.expand_path('./features', __dir__)].freeze -
However JH QA test folder is
jh/qa/qa/specs/features, which is not added inDEFAULT_TEST_PATH_ARGS, so retry JH failed qa test failed.
So I am creating this mr to append JH test folder into DEFAULT_TEST_PATH_ARGS if GitlabEdition.jh? is true, which will not effect upstream code but make retry JH failed test works.