Add jh spec features folder in qa runner for JH edition

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

JH QA team retrying to enable retry failed qa test however we found it is not working, job link.

After analyze we found

  1. examples.txt file, which contains failed test info, is generated when qa test run first time

  2. when retry failed test runs, rspec shows All examples were filtered out, which means rspec didn't load correct specs

  3. when retry failed test runs, rspec accept params like --only-failures and disable knapsack, then spec runner load folder qa/qa/specs/features as tests, because runner code below

    # qa/qa/specs/runner.rb
    DEFAULT_TEST_PATH_ARGS = ['--', File.expand_path('./features', __dir__)].freeze
  4. However JH QA test folder is jh/qa/qa/specs/features, which is not added in DEFAULT_TEST_PATH_ARGS , so retry JH failed qa test failed.

So I am creating this mr to append JH test folder into DEFAULT_TEST_PATH_ARGS if GitlabEdition.jh? is true, which will not effect upstream code but make retry JH failed test works.

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading