Explicitly require SimpleDelegator for internal events cli
What does this MR do and why?
After updating my gdk, I just ran the internal events cli locally and hit an error:
% scripts/internal_events/cli.rb
scripts/internal_events/cli.rb:128:in `<main>': uninitialized constant SimpleDelegator (NameError)
class GitlabPrompt < SimpleDelegator
^^^^^^^^^^^^^^^
This MR fixes that error by require
-ing the package needed for the Internal Events CLI to run.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- run
scripts/internal_events/cli.rb
from the gitlab directory
Merge request reports
Activity
changed milestone to %17.3
assigned to @syasonik
added pipelinetier-1 label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @shreyasagarwal
(UTC+5.5, 9.5 hours ahead of author)
@maddievn
(UTC+2, 6 hours ahead of author)
~"Tooling" Reviewer review is optional for ~"Tooling" @terrichu
(UTC-4, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User@nbelokolodov Could you review (and possibly merge?) this internal events cli fix?
requested review from @nbelokolodov
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9de9c7ebexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 67 | 0 | 2 | 0 | 69 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 30 | 0 | 1 | 0 | 31 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 372 | 0 | 30 | 0 | 402 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9de9c7ebexpand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Create | 270 | 0 | 34 | 10 | 304 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 284 | 0 | 48 | 10 | 332 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usermentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#7661 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#7663 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label