Something went wrong while fetching comments. Please try again.
Use CrudComponent for labels lists
What does this MR do and why?
- Use crud component for projects, groups label lists
- Updates list title to
Labels
when no prioritized labels exist, instead of removing the title completely - Adds counters + icon
- Use
total_count
in admin labels
What does this MR not do?
Any mobile fixes/changes. It should look the same as it currently does
Screenshots or screen recordings
Before | After | |
---|---|---|
Project | ![]() |
![]() |
Group | ![]() |
![]() |
How to set up and validate locally
- Project > Manage > labels
- Create some prioritized labels
Links
Edited by Annabel Dunstone Gray
Merge request reports
Activity
changed milestone to %17.3
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer backend @aluthra2
(UTC+5.5, 5.5 hours ahead of author)
@rymai
(UTC+2, 2 hours ahead of author)
frontend @jrushford
(UTC+2, 2 hours ahead of author)
@sdejonge
(UTC+10, 10 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Coung Ngo
added 447 commits
-
74a8a8d1...cc698930 - 446 commits from branch
master
- 5963ef82 - Use CrudComponent for labels lists
-
74a8a8d1...cc698930 - 446 commits from branch
- Resolved by Coung Ngo
@seggenberger @syarynovskyi Can you please review UX and frontend here?
Edited by Annabel Dunstone Gray
requested review from @seggenberger and @drew
requested review from @syarynovskyi
Please register or sign in to reply