Skip to content
Snippets Groups Projects

Uses until_executed for flush counter worker

Merged Vijay Hawoldar requested to merge vij-adjust-flush-counter-worker-strategy into master
All threads resolved!

What does this MR do and why?

The FlushCounterIncrementsWorker was identified as a large contributor to our WAL load.

On inspection, we appear to process approx. 1.1M of these workers every 24 hours (logs).

In an attempt to reduce any unnecessary duplicated jobs, this MR changes the worker's deduplication strategy from the until_executing to until_executed.

Refs #468287 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Vijay Hawoldar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @fabiopitino

  • mentioned in issue #468287 (closed)

  • Fabio Pitino approved this merge request

    approved this merge request

  • Fabio Pitino resolved all threads

    resolved all threads

  • added pipelinetier-3 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Fabio Pitino enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 097c75e3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
    | Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
    | Plan        | 66     | 0      | 3       | 0     | 69    | ✅     |
    | Govern      | 69     | 0      | 0       | 0     | 69    | ✅     |
    | Data Stores | 30     | 0      | 1       | 0     | 31    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 371    | 0      | 31      | 0     | 402   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 097c75e3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Fulfillment | 4      | 0      | 7       | 0     | 11    | ✅     |
    | Create      | 270    | 0      | 34      | 4     | 304   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 274    | 0      | 41      | 4     | 315   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Fabio Pitino started a merge train

    started a merge train

  • merged

  • Fabio Pitino mentioned in commit 48013e9e

    mentioned in commit 48013e9e

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading