Uses until_executed for flush counter worker
What does this MR do and why?
The FlushCounterIncrementsWorker
was identified as a large contributor to our WAL load.
On inspection, we appear to process approx. 1.1M of these workers every 24 hours (logs).
In an attempt to reduce any unnecessary duplicated jobs, this MR changes the worker's deduplication strategy from the until_executing
to until_executed
.
Refs #468287 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.3
assigned to @vij
added devopsfulfillment label
added pipelinetier-1 label
2 Warnings The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @shreyasagarwal
(UTC+5.5, 4.5 hours ahead of author)
@ayufan
(UTC+2, 1 hour ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 1 commit
- 097c75e3 - Uses until_executed for flush counter worker
- Resolved by Vijay Hawoldar
requested review from @fabiopitino
mentioned in issue #468287 (closed)
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 097c75e3expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Plan | 66 | 0 | 3 | 0 | 69 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Data Stores | 30 | 0 | 1 | 0 | 31 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 1 | 0 | 0 | 0 | 1 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 371 | 0 | 31 | 0 | 402 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 097c75e3expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Create | 270 | 0 | 34 | 4 | 304 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 274 | 0 | 41 | 4 | 315 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usermentioned in commit 48013e9e
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label