Skip to content
Snippets Groups Projects

Stop creating prometheus alert records from operations dashboard specs

Merged Sarah Yasonik requested to merge sy-rm-monitor-metrics-21 into master
All threads resolved!

What does this MR do and why?

Changes: Removes unnecessary creation of PrometheusAlert records in ee/spec/services/dashboard/operations/list_service_spec.rb. The records aren't important for the tests, and I'll be removing the association completely in a follow-up MR.

Context: This MR cleans up a portion of dead code related to the removal of devopsmonitor Category:Metrics features. The Metrics Dashboard & Prometheus Metrics/Alerts (used for monitoring apps deploying using gitlab) were deprecated in 14.7 and removed from the product in 16.0.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

These features were disabled in %16.0 behind the :remove_monitor_metrics feature flag, and have been partially deleted since then. So there's nothing really to test here. It's no longer possible to set up these features.

Edited by Sarah Yasonik

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading