Drop old unused tables for prometheus alerts

Description

Drop tables:

• issues_prometheus_alert_events
• issues_self_managed_prometheus_alert_events

See #442748 (comment 1830484684) and Respond: Create & link model classes for tables... (#442748 - closed) for details. The application code corresponding to these tables should also removed.

Implementation Plan

How to drop tables in GitLab?

• https://docs.gitlab.com/ee/development/migration_style_guide.html#dropping-a-database-table
• The tables have foreign keys, so use a post-deploy migration (probably one migration per table)
• https://docs.gitlab.com/ee/development/database/post_deployment_migrations.html
• Remove the table doc files
  • db/docs/issues_prometheus_alert_events.yml
  • db/docs/issues_self_managed_prometheus_alert_events.yml
• Similar merge request for reference !153443 (merged)

changed milestone to %17.1

added Category:Service Desk IncubationService Desk devopsservice management grouprespond maintenanceremoval sectionseg labels

assigned to @msaleiko

marked this issue as related to #442748 (closed)

added typemaintenance label

added devopsmonitor label and removed devopsservice management label

added Seeking community contributions devopsservice management quick win labels and removed devopsmonitor label

@msaleiko thanks for adding the Seeking community contributions label!

This issue's description does not seem to have a section for "Implementation Guide". Please consider adding one, because it makes a big difference for contributors. This section can be brief but must have clear technical guidance, like:

• Hints on lines of code which may need changing
• Hints on similar code/patterns that can be leveraged
• Suggestions for test coverage
• Ideas for breaking up the merge requests into iterative chunks
• Links to documentation (within GitLab or external) about implementation or testing guidelines, especially when working with third-party libraries

Need help? Reach out to the Contributor Success team in #contributor-success, or in Discord.

This message was generated automatically. You're welcome to improve it.

added devopsmonitor label and removed devopsservice management label

changed title from Drop old unused tables to Drop old unused tables for prometheus alerts

removed Category:Service Desk label

added Category:Incident Management label

changed milestone to %Backlog

mentioned in issue #442748 (closed)

changed the description

@syasonik it looks like there are still references to the tables. Is this because the work in Metrics: Delete models & database tables/columns (#397142 - closed) hasn't been finished?

For example

1. app/models/issue.rb:100

     has_and_belongs_to_many :prometheus_alert_events, join_table: :issues_prometheus_alert_events # rubocop: disable Rails/HasAndBelongsToMany

2. app/models/issue.rb:182

       scope :with_prometheus_alert_events, -> { joins(:issues_prometheus_alert_events) }

3. lib/gitlab/usage/metrics/instrumentations/issues_with_prometheus_alert_events.rb:17

   relation { Issue.with_prometheus_alert_events }

4. app/models/prometheus_alert_event.rb (this is the model that should stay, right? )

So it looks like we can remove the relations, but what about 3) and 4)?

Is this because the work in Metrics: Delete models & database tables/columns (#397142 - closed) hasn't been finished?

Yes - exactly @msaleiko! And yeah, we should be able to get rid of all of that.

@manojmj What is the best epic for this issue? Organization isolation for Cells 1.0 Phase 8 (&13678)?

removed Seeking community contributions label

added to epic &13678

mentioned in merge request !152831 (merged)

@msaleiko We have an OKR to add the schema and sharding keys for all the tables https://gitlab.com/gitlab-com/gitlab-OKRs/-/work_items/7050. We have also created !152831 (merged). I'm concerned about this issue because it is not scheduled (currently %Backlog); when do you think this issue will be scheduled and completed?

There is a similar merge request !153443 (merged) related to dropping tables. I'm posting it for reference to community contributors.

Great thank you!

@msaleiko You are assigned here. Are you planning to work on this soon?

@syasonik Can you please double-check the description? Marc is OOO, and I want to add this for Seeking community contributions, but we need to have a good implementation plan so they can work on it.

Description looks good @arturoherrero. I just added a note that this issue will include some app code cleanup too, since a few associations/references to these tables still exist.

Thanks @syasonik and @arturoherrero

unassigned @msaleiko

marked this issue as related to #397142 (closed)

changed the description

changed the description

added Seeking community contributions label

mentioned in issue #465723

mentioned in commit 7d3e6ce0

Assigning myself to do the code cleanup here ahead of grouptenant scale dropping the tables.

Moving this to %17.2 to complete this during the milestone.

assigned to @syasonik

removed Seeking community contributions label

marked this issue as related to #465875 (closed)

changed milestone to %17.2

changed milestone to %17.3

added missed:17.2 label

mentioned in merge request !160067 (merged)

mentioned in issue gitlab-org/database-team/team-tasks#447 (closed)

mentioned in merge request !160325 (closed)

mentioned in merge request !160481 (merged)

mentioned in merge request !160482 (merged)

mentioned in merge request !160483 (merged)

mentioned in merge request !160485 (merged)

mentioned in merge request !160488 (merged)

mentioned in merge request !160489 (merged)

mentioned in merge request !160492 (merged)

mentioned in merge request !160493 (merged)

mentioned in merge request !160494 (merged)

mentioned in merge request !160496 (merged)

mentioned in merge request !160497 (merged)

mentioned in merge request !160498 (merged)

mentioned in merge request !160499 (merged)

mentioned in merge request !160500 (merged)

mentioned in merge request !160501 (merged)

mentioned in merge request !160502 (merged)

mentioned in merge request !160504 (merged)

mentioned in merge request !160505 (merged)

mentioned in merge request !160506 (merged)

mentioned in merge request !160508 (merged)

mentioned in merge request !160509 (merged)

mentioned in merge request !160511 (merged)

mentioned in merge request !160606 (closed)

mentioned in merge request !160616 (merged)

mentioned in merge request !160641 (merged)

mentioned in issue #474533 (closed)

marked this issue as related to #474533 (closed)

added workflowin dev label

mentioned in merge request !161821 (merged)

mentioned in merge request !162630 (merged)

changed milestone to %17.4

added missed:17.3 label

added groupanalytics instrumentation sectionanalytics labels and removed grouprespond sectionseg labels

added Category:Metrics label

removed Category:Incident Management label

set weight to 3

mentioned in merge request !162799 (merged)

mentioned in merge request !162908 (merged)

mentioned in merge request !162908 (merged)

mentioned in merge request !162909 (merged)

mentioned in merge request !162918 (merged)

mentioned in merge request !162921 (merged)

mentioned in merge request !162922 (merged)

mentioned in issue #474534

mentioned in issue #465327

mentioned in merge request !164288 (merged)

added workflowin review label and removed workflowin dev label

The final MR to drop these tables has merged! Closing.

closed

added workflowverification label and removed workflowin review label